Development - go.mod and gitignore #466
Description
Description
The go.mod seems to be out of sync with the project, every time I build it for tests it is modified:
golang.org/x/image v0.0.0-20190802002840-cff245a6509b
Also, I would like to update the gitignore to ignore the test files that get generated during the test suites execution. Would you accept a PR that updated the gitignore and go.mod?
Metadata
Metadata
Assignees
Labels
No labels
Type
Projects
Milestone
Relationships
Development
No branches or pull requests
Participants
Activity
dolmen commentedon Aug 13, 2019
Modification of
.gitignoreshould be a separate PR.mlh758 commentedon Aug 13, 2019
Separate PRs for updating
.gitignoreand the mod file?dolmen commentedon Aug 13, 2019
Yes.
.gitignorein one commit in one PR.For
go.mod+go.sum, I think that should be the job of the maintainer because (s)he should know better what the minimum version of the dependencies are supported.Note that I'm not the maintainer. Just a contributor who follows the project for two years now and uses it in production code.
bvwells commentedon Sep 13, 2019
On top of this, building master brings in v1 of the module due to incorrect import paths in test code. See #480.
Fix qax-os#466, qax-os#480 Merge pull request qax-os#481 from bvwells…
Fix qax-os#466, qax-os#480 Merge pull request qax-os#481 from bvwells…