Skip to content

ENABLE_CCACHE option didn't work #4648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 21, 2022
Merged

Conversation

lipzhu
Copy link
Contributor

@lipzhu lipzhu commented Sep 15, 2022

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Description:

When I want to disable the ccache, found the option ENABLE_CCACHE which defined in GeneralCMakeOptions.cmake didn't work.

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

Sorry, something went wrong.

@lipzhu lipzhu requested a review from a team as a code owner September 15, 2022 08:51
@Sophie-Xie Sophie-Xie requested a review from dutor September 15, 2022 08:55
Copy link
Contributor

@dutor dutor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@Sophie-Xie Sophie-Xie added the ready-for-testing PR: ready for the CI test label Sep 21, 2022
@Sophie-Xie Sophie-Xie requested a review from jievince September 21, 2022 02:05

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@Sophie-Xie Sophie-Xie merged commit 39faaa1 into vesoft-inc:master Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants