Skip to content

Fix/fix log file #4409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 18, 2022
Merged

Fix/fix log file #4409

merged 6 commits into from
Jul 18, 2022
+9 −4

Conversation

Shylock-Hg
Copy link
Contributor

@Shylock-Hg Shylock-Hg commented Jul 13, 2022 •
edited
Loading

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Description:

Fix the corruption of log file.
Now when set timestamp_in_logfile_name=false, log will write to logs/nebula-graphd.INFO.impl and symbol link logs/nebula-graphd.INFO is same as before. It's same for WARNING/ERROR logs and same for metad and storaged.

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.）
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

Sorry, something went wrong.

@Shylock-Hg Shylock-Hg added type/bug Type: something is unexpected ready-for-testing PR: ready for the CI test labels Jul 13, 2022
@Shylock-Hg
Merge branch 'master' into fix/fix-log-file

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
a891c6e
@Sophie-Xie Sophie-Xie linked an issue Jul 14, 2022 that may be closed by this pull request
Set the parameter timestamp_in_logfile_name=false cause log report wrong information for logrotate setups #4411
Closed
@Shylock-Hg Shylock-Hg marked this pull request as ready for review July 15, 2022 02:55
@Shylock-Hg
Merge branch 'master' into fix/fix-log-file

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
bdf327d
@codecov-commenter
Copy link

Codecov Report

Merging #4409 (bdf327d) into master (7079ef5) will increase coverage by 0.07%.
The diff coverage is 12.50%.

@@            Coverage Diff             @@
##           master    #4409      +/-   ##
==========================================
+ Coverage   84.53%   84.60%   +0.07%     
==========================================
  Files        1345     1345              
  Lines      134046   134051       +5     
==========================================
+ Hits       113318   113417      +99     
+ Misses      20728    20634      -94
Impacted Files Coverage Δ
...c/meta/processors/job/LeaderBalanceJobExecutor.cpp 85.88% <ø> (-0.05%) ⬇️
src/daemons/SetupLogging.cpp 55.55% <12.50%> (-5.32%) ⬇️
src/graph/context/Result.cpp 70.00% <0.00%> (-7.78%) ⬇️
src/common/thread/GenericWorker.h 80.76% <0.00%> (-3.85%) ⬇️
src/parser/GraphScanner.h 92.63% <0.00%> (-2.00%) ⬇️
src/kvstore/Part.cpp 53.55% <0.00%> (-1.92%) ⬇️
src/graph/optimizer/Optimizer.cpp 91.52% <0.00%> (-1.70%) ⬇️
src/kvstore/raftex/RaftPart.cpp 70.78% <0.00%> (-0.90%) ⬇️
src/graph/executor/Executor.cpp 79.50% <0.00%> (-0.50%) ⬇️
src/storage/test/StatsTaskTest.cpp 94.61% <0.00%> (-0.45%) ⬇️
... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7981108...bdf327d. Read the comment docs.

@Sophie-Xie Sophie-Xie added this to the v3.3.0 milestone Jul 18, 2022
@Sophie-Xie
Merge branch 'master' into fix/fix-log-file

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
74e42d4
@Sophie-Xie
Merge branch 'master' into fix/fix-log-file

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
b914e94
@Sophie-Xie Sophie-Xie merged commit d33241c into vesoft-inc:master Jul 18, 2022
@Shylock-Hg Shylock-Hg deleted the fix/fix-log-file branch July 19, 2022 08:31
@Shylock-Hg Shylock-Hg mentioned this pull request Jul 19, 2022
Merged
11 tasks
@wey-gu wey-gu mentioned this pull request Jul 23, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@critical27 critical27

@czpmango czpmango

@nevermore3 nevermore3

Assignees
No one assigned
Labels
ready-for-testing PR: ready for the CI test type/bug Type: something is unexpected
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.

Set the parameter timestamp_in_logfile_name=false cause log report wrong information for logrotate setups
5 participants
@Shylock-Hg @codecov-commenter @critical27 @czpmango @Sophie-Xie