Support to enable rocksdbs statistics #2243
Merged
+76
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If so I think you could export the option |
Shylock-Hg
reviewed
Jul 23, 2020
I think we can specify this in --rocksdb_db_options |
|
Thanks for your advise, can you help to review again.@dutor |
dangleptr
previously approved these changes
Jul 24, 2020
|
Please check your code style with cpplint. |
chenxu14
force-pushed
the
statistics-enable
branch
from
937fb2a to
e9ff598
Compare
OK, fixed |
dutor
approved these changes
Jul 27, 2020
dutor
added
ready-for-testing
dangleptr
approved these changes
Jul 27, 2020
xuguruogu
pushed a commit
to xuguruogu/nebula
that referenced
this pull request
Aug 5, 2020
tong-hao
pushed a commit
to tong-hao/nebula
that referenced
this pull request
Jun 1, 2021
yixinglu
pushed a commit
to yixinglu/nebula
that referenced
this pull request
Jan 31, 2023
…soft-inc#2243) Co-authored-by: kyle.cao <kyle.cao@vesoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think there is a need to enable rocksdb's statistics, so we can dump some metrics to the log, and use it to find bottleneck.
We can enable this by specify --rocksdb_statistics_enable=true in nebula-storaged.conf, and declare the stats level through --rocksdb_stats_level(default value is kExceptHistogramOrTimers)