meta client thread local access. #2165
Merged
+214
−122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xuguruogu
force-pushed
the
meta-client-thread-local
branch
from
be98763 to
498b5cd
Compare
|
the issue came from compaction. before the changes: after the changes: |
|
Thanks for this improvement. I also noticed this issue recently, and did some similar optimization. Many other modules may benefit from this patch. |
dangleptr
previously approved these changes
Jun 8, 2020
|
Please recheck the Failed UTs |
Codecov Report
@@ Coverage Diff @@
## master #2165 +/- ##
==========================================
- Coverage 86.40% 86.39% -0.01%
==========================================
Files 643 643
Lines 62686 62722 +36
==========================================
+ Hits 54161 54187 +26
- Misses 8525 8535 +10
Continue to review full report at Codecov.
|
xuguruogu
force-pushed
the
meta-client-thread-local
branch
from
52e2391 to
bfe67fc
Compare
|
centos7 unit tests is killed. may due to make oom |
dangleptr
approved these changes
Jun 15, 2020
tong-hao
pushed a commit
to tong-hao/nebula
that referenced
this pull request
Jun 1, 2021
…c op. (vesoft-inc#2165) Co-authored-by: trippli <trippli@tencent.com> Co-authored-by: dutor <440396+dutor@users.noreply.github.com> Co-authored-by: dangleptr <37216992+dangleptr@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use thread local object when access meta client cache. folly::SingletonThreadLocal supply efficient access wrapper by using pointer.