Support default value when create tag and edge. #860
Conversation
darionyaphet
requested review from
dutor,
CPWstatic,
critical27,
wadeliuyi,
dangleptr,
laura-ding and
whitewum
src/graph/InsertEdgeExecutor.cpp
Outdated
|
|
||
| VLOG(3) << "Insert " << fieldName << ":" << variantType | ||
| << " at " << insertPosition; | ||
| values.insert(values.begin() + insertPosition, std::move(variantType)); |
There was a problem hiding this comment.
in this function, maybe list for values is better than vector.
src/graph/InsertEdgeExecutor.cpp
Outdated
| return Status::Error("Unknow type"); | ||
| } | ||
| insertPosition++; | ||
| } else if (*props_[propsIndex] == fieldName) { |
There was a problem hiding this comment.
why here we can visit props_ by order, but in function check we visit it by find_if ?
| return Status::Error("Wrong number of value"); | ||
| auto schemaNumFields = schema->getNumFields(); | ||
| size_t propsIndex = 0; | ||
| for (size_t schemaIndex = 0; schemaIndex < schemaNumFields; schemaIndex++) { |
There was a problem hiding this comment.
maybe can do this in sub function
| TagID tagId, | ||
| const std::string& field) { | ||
| cpp2::GetReq req; | ||
| static std::string defaultKey = "__default__"; |
There was a problem hiding this comment.
the default value maybe can cached in client.
There was a problem hiding this comment.
Yep Good Point ~
| LOG(INFO) << "Create Edge " << req.get_edge_name() << ", edgeType " << edgeType; | ||
| auto columns = req.get_schema().get_columns(); | ||
| for (auto& column : columns) { | ||
| if (column.__isset.default_value) { |
src/graph/InsertEdgeExecutor.cpp
Outdated
| propsIndex++; | ||
| insertPosition++; | ||
| } else { | ||
| insertPosition++; |
There was a problem hiding this comment.
Why we can increase the position here? It seems you handle the situation when props_[propsIndex] mismatch with fieldName in if statement, and match in previous else if. Explain a little please.
|
Question: How to modify the default value? for the first time, I set int as 0; and the second time, I hope a int is -1? |
According to Maybe there are some related works for this PR for example: |
|
Unit testing passed. |
|
Unit testing passed. |
|
Unit testing passed. |
* default value * support default value
* default value * support default value
#631