-
Notifications
You must be signed in to change notification settings - Fork 2k
Refactoring comments #711
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring comments #711
Conversation
Another problem is that some plug-ins provide multiple services, like Function: # choice your comments service
comments_service:
# choice your likes service
likes_service: Provider: # choice VKontakte provider
VKontakte: enable: true
# choice Facebook provider
Facebook: enable: true |
It might be better to split them according to function, like how we deal with Google calendar, Google analytics, Google site verification, etc |
I've been a little busy recently, will test every comment plug-in over a period of time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll test VK soon, ok.
Does anyone need help? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems VK API must work's fine.
So only Changyan is needed to be tested now? |
@jiangtj Conflict needs to be resolved |
@stevenjoezhang You can merge it, but #764 needs a lot of improvement. |
Any new progress here? |
我还在考虑怎么弄,想将评论显示的位置也作为一个注入点,那样与post-meta body-end一起,对应文件夹下的那三个文件,而且用注入的方式理论上不会打破兼容性 但这样,就得到了一个数组,所以对多评论系统的支持这块,需要提前思考🤔 I'm still thinking about how to do it, and I want to use the location of the comment display as a injection point, so that, together with post-meta body-end, the three files under the folder, and the injection method doesn't theoretically break compatibility, but in this way, I get an array, so the support for the multi-comment system needs to think about it in advance. |
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue resolved: N/A
What is the new behavior?
I put all the comments code into a folder. So we can add comment plug-ins more easily. Only add or modify files in their folder.

But a lot of testing is needed, and incompatibility with the original configuration can affect many users.
So do you think we should make such a change?
How to use?
In NexT
_config.yml
:Does this PR introduce a breaking change?