Migrate to Font-Awesome 5 #1438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sli1989
reviewed
Mar 30, 2020
| @@ -49,7 +49,7 @@ | |||
| {%- if theme.post_meta.created_at %} | |||
| <span class="post-meta-item"> | |||
| <span class="post-meta-item-icon"> | |||
| <i class="fa fa-calendar-o"></i> | |||
| <i class="far fa-calendar"></i> | |||
There was a problem hiding this comment.
Some far are free, and some of the original v4 icons are far in v5
sli1989
reviewed
Mar 30, 2020
| @@ -1,4 +1,4 @@ | |||
| {%- set ccIcon = '<i class="fa fa-fw fa-creative-commons"></i>' %} | |||
| {%- set ccIcon = '<i class="fab fa-fw fa-creative-commons"></i>' %} | |||
There was a problem hiding this comment.
just fused about fa/far/fab? a huge update. thanks.
There was a problem hiding this comment.
I did not find the official documentation for migration from v4.7 to v5. In fact, this PR is based on this gist: https://github.com/estebandelaf/scripts/blob/master/fontawesome4to5.sh
About new class names:
fas for solid
far for regular
fab for brand
|
Shall we merge this PR to v7.8.0 release (April 1st)? |
This was referenced Mar 31, 2020
Closed
This was
linked to
issues
Mar 31, 2020
Closed
Guoye
added a commit
to Guoye/hexo-theme-next
that referenced
this pull request
Apr 22, 2020
* 'master' of https://github.com/theme-next/hexo-theme-next: (99 commits) Optimize main-menu & sidebar-nav style Optimize dark mode blockquote style Use fixed-width icons in copy-btn Fix exturl title Fix Font Awesome path and font-family Fix Font Awesome class name Migrate to Font Awesome 5 (theme-next#1438) Release v7.8.0 Optimize dark mode button color Fix theme-next#1424: Dark mode footer color of scheme Mist Optimize dark mode colors Combine .content and .posts-expand Optimize mobile_layout_economy New Crowdin translations (theme-next#1413) Some minor fixes Revert theme-next#1124: Class name for pages Run lebab Trigger search after loading is complete Simplify footer.powered settings (theme-next#1432) Remove `seo` option in `_config.yml` (theme-next#1414) ... # Conflicts: # _config.yml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue resolved: #505