Skip to content

x_train_bin may also be filtered #212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 5, 2020

Conversation

tiancheng2000
Copy link
Contributor

Both qnn and fair_nn are based on binary encoded x_train_bin, however this dataset is full of contradictory examples (7789 out of 11520). Though already mentioned in the doc, "binarizing will cause more collisions", it might be unclear to a part of readers that the ratio of collision exceeded 67.6%! and this ratio will affect classificaion training.

Both `qnn` and `fair_nn` are based on binary encoded `x_train_bin`, however this dataset is full of contradictory examples (7789 out of 11520). Though already mentioned in the doc, "binarizing will cause more collisions", it might be unclear to a part of readers that the ratio of collision exceeded 67.6%! and this ratio will affect classificaion training.
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

You'll be able to see Jupyter notebook diff and discuss changes. Powered by ReviewNB.

Sorry, something went wrong.

@MichaelBroughton
Copy link
Collaborator

Gentle reminder @MarkDaoust

Sorry, something went wrong.

@MichaelBroughton MichaelBroughton merged commit a78c79a into tensorflow:master May 5, 2020
jaeyoo pushed a commit to jaeyoo/quantum that referenced this pull request Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants