-
Notifications
You must be signed in to change notification settings - Fork 599
y_train_hinge must be paired with y_train_nocon #211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
y_train_hinge should be accordance with x_train_tfcirc, which originates from x_train_nocon
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
Check out this pull request on You'll be able to see Jupyter notebook diff and discuss changes. Powered by ReviewNB. |
@googlebot I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
update the doc
Gentle reminder @MarkDaoust |
I had to pin cirq==0.7 to make this work, otherwise (cirq==0.8) import
|
This change looks correct to me, I'm not sure how it got broken, but I'm running it once to confirm that everything works. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Running in Colab, this is obviously making progress, (unlike the version with the scrambled labels). So LGTM.
Fix integer parameters in qsimcirq.
y_train_hinge
, as labels, must be accordance withx_train_tfcirc
, which originated fromx_train_nocon
.Otherwise there will be lots of mismatches between
xs
andys
on training.