Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

y_train_hinge must be paired with y_train_nocon #211

Merged
merged 4 commits into from May 5, 2020

Conversation

tiancheng2000
Copy link
Contributor

y_train_hinge, as labels, must be accordance with x_train_tfcirc, which originated from x_train_nocon.
Otherwise there will be lots of mismatches between xs and ys on training.

y_train_hinge should be accordance with x_train_tfcirc, which originates from x_train_nocon
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

You'll be able to see Jupyter notebook diff and discuss changes. Powered by ReviewNB.

@tiancheng2000
Copy link
Contributor Author

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@MichaelBroughton
Copy link
Collaborator

Gentle reminder @MarkDaoust

@MarkDaoust
Copy link
Member

@MichaelBroughton

I had to pin cirq==0.7 to make this work, otherwise (cirq==0.8) import tfq fails with

/usr/local/lib/python3.6/dist-packages/tensorflow_quantum/core/serialize/serializer.py in _eigen_gate_serializer(gate_type, serialized_id)
    112             serialized_name="exponent",
    113             serialized_type=float,
--> 114             gate_getter=lambda x: _symbol_extractor(x.exponent)),
    115         cirq.google.SerializingArg(
    116             serialized_name="exponent_scalar",

TypeError: __init__() got an unexpected keyword argument 'gate_getter'

@MarkDaoust
Copy link
Member

MarkDaoust commented May 4, 2020

This change looks correct to me, I'm not sure how it got broken, but I'm running it once to confirm that everything works.

Copy link
Member

@MarkDaoust MarkDaoust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Running in Colab, this is obviously making progress, (unlike the version with the scrambled labels). So LGTM.

@MichaelBroughton MichaelBroughton merged commit 2294622 into tensorflow:master May 5, 2020
jaeyoo pushed a commit to jaeyoo/quantum that referenced this pull request Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants