When cachemode is connection, setting channel.checkout-timeout will cause the first createConnection to wait for checkout-timeout. #1026

kongwu- · 2019-06-15T13:21:18Z

Bug report

version: 2.1.6-RELEASE

When cachemode is connection, setting channel.checkout-timeout will cause the first createConnection to wait for checkout-timeout ms

application.properties

spring.rabbitmq.addresses=localhost:5672
server.port=8082
spring.rabbitmq.cache.connection.mode=connection
spring.rabbitmq.cache.channel.checkout-timeout=100000

java code

@GetMapping("send")
public String send(String msg){
    // When the first message is sent, createConnection will cause blocking of channel.checkout-timeout ms.
    rabbitTemplate.convertAndSend("test-queue",msg);
    return msg;
}

CachingConnectionFactory#waitForConnection

private ChannelCachingConnectionProxy waitForConnection(long now) {
		ChannelCachingConnectionProxy cachedConnection = null;
                //I think the problem should not wait in this spin-waiting, the first time you create a connection.
		while (cachedConnection == null && System.currentTimeMillis() - now < this.channelCheckoutTimeout) {
			if (countOpenConnections() >= this.connectionLimit) {
				try {
					this.connectionMonitor.wait(this.channelCheckoutTimeout);
					cachedConnection = findIdleConnection();
				}
				catch (InterruptedException e) {
					Thread.currentThread().interrupt();
					throw new AmqpException("Interrupted while waiting for a connection", e);
				}
			}
		}
		return cachedConnection;
	}

Fixes spring-projects#1026 When using a `channelCheckoutTimeout` with `CacheModeConnection`, we incorrectly spin waiting for a connection until the timeout expires. We should only wait for a connection if the limit is exceeded. **cherry-pick to all supported**

Fixes #1026 When using a `channelCheckoutTimeout` with `CacheModeConnection`, we incorrectly spin waiting for a connection until the timeout expires. We should only wait for a connection if the limit is exceeded. **cherry-pick to all supported**

Fixes #1026 When using a `channelCheckoutTimeout` with `CacheModeConnection`, we incorrectly spin waiting for a connection until the timeout expires. We should only wait for a connection if the limit is exceeded. **cherry-pick to all supported** (cherry picked from commit dde7a37)

Fixes #1026 When using a `channelCheckoutTimeout` with `CacheModeConnection`, we incorrectly spin waiting for a connection until the timeout expires. We should only wait for a connection if the limit is exceeded. **cherry-pick to all supported** (cherry picked from commit dde7a37) # Conflicts: # spring-rabbit/src/main/java/org/springframework/amqp/rabbit/connection/CachingConnectionFactory.java # spring-rabbit/src/test/java/org/springframework/amqp/rabbit/connection/CachingConnectionFactoryTests.java

Fixes #1026 When using a `channelCheckoutTimeout` with `CacheModeConnection`, we incorrectly spin waiting for a connection until the timeout expires. We should only wait for a connection if the limit is exceeded. **cherry-pick to all supported** (cherry picked from commit dde7a37) # Conflicts: # spring-rabbit/src/main/java/org/springframework/amqp/rabbit/connection/CachingConnectionFactory.java # spring-rabbit/src/test/java/org/springframework/amqp/rabbit/connection/CachingConnectionFactoryTests.java # Conflicts: # spring-rabbit/src/test/java/org/springframework/amqp/rabbit/connection/CachingConnectionFactoryTests.java

garyrussell added this to the 2.1.8 milestone Jun 17, 2019

garyrussell added the type: bug label Jun 17, 2019

garyrussell self-assigned this Jun 17, 2019

garyrussell mentioned this issue Jun 17, 2019

GH-1026: Fix Delay with CacheMode.CONNECTION #1027

Merged

artembilan closed this as completed in #1027 Jun 17, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

When cachemode is connection, setting channel.checkout-timeout will cause the first createConnection to wait for checkout-timeout. #1026

When cachemode is connection, setting channel.checkout-timeout will cause the first createConnection to wait for checkout-timeout. #1026

kongwu- commented Jun 15, 2019 •

edited

Loading

When cachemode is connection, setting channel.checkout-timeout will cause the first createConnection to wait for checkout-timeout. #1026

When cachemode is connection, setting channel.checkout-timeout will cause the first createConnection to wait for checkout-timeout. #1026

Comments

kongwu- commented Jun 15, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bug report

kongwu- commented Jun 15, 2019 •

edited

Loading