Skip to content

More friendly hints in dynamic URL. #713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

crossoverJie
Copy link

fix #712

@spencergibb
Copy link
Member

I don't understand how this makes sense

@crossoverJie
Copy link
Author

When I used it this way it never worked as expected, and after looking up a lot of information and source code I found that it only needed the url not to be equal to the empty string to work.

But the official comments don't explain much, so this will help other developers who are careless like me.

	@FeignClient(name = "dynamic")
	interface DynamicClient {

		@RequestLine("GET /")
		String get(URI uri);
	}

@spencergibb
Copy link
Member

Can you please provide a complete, minimal, verifiable sample (something that we can unzip attached to this issue or git clone, build, and deploy) that reproduces the problem.

@OlgaMaciaszek
Copy link
Collaborator

Hello, @crossoverJie; thanks for submitting a PR. The 2.2.x branch is no longer supported. The test you've provided does not reproduce a valid use-case. Also, it lacks any assertion. Apart from this, I don't think we should be adding a String constant just for the benefit of linking to it from the javadoc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants