Closed
Description
The hystrix support in FeignClients is a nice to have but there is little indication that it is enabled by default and causes a number of problems. You may not even want circuit breakers in your client but you are getting them just by using Feign. An opt in approach would be more ideal, where the user has to enable Hystrix for their FeignClients in their app.
Metadata
Metadata
Assignees
Labels
No labels
Type
Projects
Relationships
Development
No branches or pull requests
Participants
Activity
daniellavoie commentedon Aug 18, 2016
I like the idea that it would be deactivated by default. What would be the condition to activate it ? Classpath detection or property configuration ?
spencergibb commentedon Aug 18, 2016
classpath + property
daniellavoie commentedon Aug 18, 2016
I mean, If I just have hystrix in my classpath, would it be enough to active it ? Or will I have to also active a property ?
spencergibb commentedon Aug 18, 2016
It's currently just classpath.
spencergibb commentedon Aug 18, 2016
So you'll have to set a property
spencergibb commentedon Aug 26, 2016
@ryanjbaxter @dsyer do we want to do this in Camden?
ryanjbaxter commentedon Aug 26, 2016
I think so
ryanjbaxter commentedon Feb 23, 2017
@spencergibb @dsyer I think we should def do this for Dalston, thoughts?
spencergibb commentedon Feb 28, 2017
Sure. Needs to be documented and in the release notes.
[-]Diable HystrixCommands For FeignClients By Default[/-][+]Disable HystrixCommands For FeignClients By Default[/+]20 remaining items