RequestSizeGatewayFilterFactory added #376
Closed
+101
−164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, Any comment on this |
|
When I get back from holidays next week |
spencergibb
requested changes
Jul 5, 2018
| @@ -17,6 +17,9 @@ | |||
|
|
|||
| package org.springframework.cloud.gateway.config; | |||
|
|
|||
|
|
|||
| import com.netflix.hystrix.HystrixObservableCommand; | |||
There was a problem hiding this comment.
Please use our import rules.
| * @author Arpan | ||
| */ | ||
| public class RequestSizeGatewayFilterFactory | ||
| extends AbstractGatewayFilterFactory<RequestSizeGatewayFilterFactory.RequestSizeConfig> { |
Take the updated code
Codecov Report
@@ Coverage Diff @@
## master #376 +/- ##
==========================================
- Coverage 65.36% 62.43% -2.93%
==========================================
Files 4 8 +4
Lines 231 410 +179
Branches 17 34 +17
==========================================
+ Hits 151 256 +105
- Misses 68 130 +62
- Partials 12 24 +12
Continue to review full report at Codecov.
|
Merged
|
Created a new pull request with the review comment integrated; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RequestSizeGatewayFilterFactory added. Which can restrict a request from reaching the downstream service , if the size of request is greater than the permissible limit. The filter can be configured in standard way. Following is an example:
And the configuration for the filter is: When it works as a default filter:
When needs to be applied in some API