-
Notifications
You must be signed in to change notification settings - Fork 538
After enable TTL, DeregisterCriticalServiceAfter not working . #490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I think that the |
I know the |
Same issue. Could you please add DeregisterCriticalServiceAfter feature on TTL checks. Thanks! |
@scrat98 PRs welcome |
* Service health check ttl with critical timeout fixes gh-490
I used the following config to enable the TTL and DeregisterCriticalServiceAfter.
When the application crash(exit without executing the deregister ),the application will be in the critical status on consul ui and never be removed by consul.
I read the code and found that the other parameters are ignored when the ttl are enable.
So my question is: Why the DeregisterCriticalServiceAfter is ignored.
Since it is not conflict with the ttl. And I check the consul.io document.
I alse test with the following curl script.The application:test-critical will be removed by consul automatically after 1 minute
The text was updated successfully, but these errors were encountered: