Closed
Description
A heads-up to anyone upgrading beyond NDK r23 beta 2:
error: linking with `~/Android/Sdk/ndk/23.0.7272597/toolchains/llvm/prebuilt/linux-x86_64/bin/aarch64-linux-android30-clang` failed: exit status: 1
|
= note: "~/Android/Sdk/ndk/23.0.7272597/toolchains/llvm/prebuilt/linux-x86_64/bin/aarch64-linux-android30-clang" "-Wl,--allow-multiple-definition" "-Wl,--eh-frame-hdr" "-Wl,-znoexecstack" "-Wl,--as-needed" "-L" "~/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/aarch64-linux-android/lib" ... "-Wl,--gc-sections" "-shared" "-Wl,-zrelro" "-Wl,-znow" "-nodefaultlibs" "-L" "android-ndk-rs/target/aarch64-linux-android/debug/deps" "-L" "android-ndk-rs/target/debug/deps" "-L" "~/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/aarch64-linux-android/lib" "-Wl,-Bstatic" ... "-Wl,-Bdynamic" "-landroid" "-ldl" "-llog" "-lgcc" "-lc" "-lm"
= note: ld: error: unable to find library -lgcc
clang-12: error: linker command failed with exit code 1 (use -v to see invocation)
error: aborting due to previous error
error: could not compile `ndk-examples`
r23 beta 2 is still working fine as per #137.
GCC Is being completely removed from the NDK, but unfortunately something deep down in Rust depends on gcc. This also happens on a project without dependencies built with cargo b --target aarch64-linux-android.
The possible cause for these is:
https://github.com/rust-lang/rust/blob/9a3214e9be41a5d50ae6ba9bb8422dcc2cb10473/library/std/src/sys/unix/mod.rs#L210-L214
I'll see whether Rust really needs to link against libgcc and if that can otherwise be replaced with libclang_rt.builtins as per https://github.com/android/ndk/wiki/Changelog-r23#changes / android/ndk#1231, without breaking existing builds.
Metadata
Metadata
Assignees
Type
Projects
Milestone
Relationships
Participants
Activity
MarijnS95 commentedon Jun 16, 2021
It looks like this has been fixed with rust-lang/rust#85806 🥳
Unfortunately it has not reached nightly yet, will close this when it is confirmed fixed.
Change ndk to older version
ar37-rs commentedon Nov 9, 2021
MarijnS95 commentedon Nov 9, 2021
Please don't download or use undocumented rar files from random people on the internet.
Aforementioned Rust PR unfortunately doesn't fix it as the older NDK installed on the CI seems to add
-lgccback to the linker flags (rust-lang/rust#85806 (comment)). This can be solved by using nightly and buildingstdlocally by setting-Zbuild-std, but it's also something we can fix from android-ndk-rs by providing alibgcc.alinker script that requests linking withlibunwindinstead: termux/termux-packages#7339 (comment)We can do this by either:
libgcc.aon one of the existing linker paths, such astarget/<triple>/debug/deps- but this requires acargo cleanor removing the file if the user switches to a different (older) NDK;RUSTFLAGSwith-C linker-args=-L...when callingcargo build, but this is mutually exclusive with the other ways of configuringrustflags;cargo rustcand pass-- -L/the/pathto a custom location where we writelibgcc.a.We'd only want to do this if the NDK is >= r23 as to not break r22. The first option won't remove the linker script from the path again which likely has adverse effects.
ar37-rs commentedon Nov 9, 2021
@MarijnS95 what? i'm just offering the temporary solution, there's no stupid scams or viruses inside that .rar file.
ar37-rs commentedon Nov 9, 2021
"Switch to cargo rustc and pass -- -L/the/path to a custom location where we write libgcc.a" exactly, that's. just take "libgcc.a" for every arch, anyway mine's taken from NDK-r21d, working fine so far.
MarijnS95 commentedon Nov 9, 2021
We'll write
libgcc.awhich includes exactlyINPUT(-lunwind)as reviewable text. Not some binary that has been copied from hopefully an earlier NDK. Your repository doesn't even document where the files originate from.ar37-rs commentedon Nov 9, 2021
@MarijnS95 just take them yourself from the earlier NDK (r21d), if you don't have any, download from official google repo and if there's not available, just extract from .rar file above. i swear there's no virus at all.
jfgoog commentedon Nov 15, 2021
It looks like this was fixed in rust-lang/rust@965997b and so using a Rust nightly more recent than ~Jun 2021 should work.
MarijnS95 commentedon Nov 15, 2021
@jfgoog please see rust-lang/rust#85806 (comment) and other replies below.
Supposedly Rust's std/toolchain is built with an older NDK that includes a linker statement for libgcc regardless of that patch. Feel free to try it out for yourself on a recent Rust release or nightly, too.
jfgoog commentedon Nov 15, 2021
Cool! Glad to see progress on this, and sorry for the drive-by comment.
MarijnS95 commentedon Nov 15, 2021
@jfgoog no worries, I thought I had mentioned that that Rust patch unfortunately hasn't fixed it, hence the need for a workaround. Now that that's in I'll make a new release today or tomorrow, stay tuned!
-lgccbuilding for android BlockstreamResearch/rust-secp256k1-zkp#51lordadamson commentedon Aug 8, 2022
@ar37-rs that's exactly what someone who is sending a virus would say (i'm just kidding, thanks man 😂 )