Skip to content

ceph: fix osd number detection on upgrade #5606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 5, 2020
Merged

ceph: fix osd number detection on upgrade #5606

merged 2 commits into from
Jun 5, 2020
+13 −17

Conversation

leseb
Copy link
Member

@leseb leseb commented Jun 5, 2020 •
edited
Loading

Description of your changes:

If the cluster has 3 OSDs, during the upgrade when the OSD restarts it
will temporarily disappear from the "ceph versions" list so we need
a more robust way to list the number of OSDs and always returns the total
number of OSDs.

Which issue is resolved by this Pull Request:
Resolves #5521

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • Skip Tests for Docs: Add the flag for skipping the build if this is only a documentation change. See here for the flag.
  • Skip Unrelated Tests: Add a flag to run tests for a specific storage provider. See test options.
  • Reviewed the developer guide on Submitting a Pull Request
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.
  • Pending release notes updated with breaking and/or notable changes, if necessary.
  • Upgrade from previous release is tested and upgrade user guide is updated, if necessary.
  • Code generation (make codegen) has been run to update object specifications, if necessary.

[test ceph]

Sorry, something went wrong.

leseb added 2 commits June 5, 2020 15:06
@leseb
ceph: check if ok-to-stop even on failure
5520ee3 
Even if we cannot determine wheter all the OSDs are running on the host,
we still need to perform the ok-to-stop check. It is far more common to
have more than 3 OSDs anyways.

Signed-off-by: Sébastien Han <seb@redhat.com>
@leseb
ceph: fix osd number detection on upgrade
3c7a252 
If the cluster has 3 OSDs, during the upgrade when the OSD restarts it
will temporarily disappear from the "ceph versions" list so we need a
more robust way to list the number of OSDs and always returns the total
number of OSDs.

Closes: rook#5521
Signed-off-by: Sébastien Han <seb@redhat.com>
@leseb leseb requested a review from travisn June 5, 2020 13:21
@leseb leseb merged commit 8592cae into rook:master Jun 5, 2020
@leseb leseb deleted the fix-5521 branch June 5, 2020 15:12
@mergify mergify bot mentioned this pull request Jun 5, 2020
Merged
mergify bot added a commit that referenced this pull request Jun 8, 2020
@mergify
Merge pull request #5610 from rook/mergify/bp/release-1.3/pr-5606

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
77f1b7e 
ceph: fix osd number detection on upgrade (bp #5606)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@travisn travisn

Assignees
No one assigned
Labels
ceph main ceph tag
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OSDs are upgraded too soon after each other
2 participants
@leseb @travisn