-
Notifications
You must be signed in to change notification settings - Fork 671
Rephrase responseTimeout
Javadoc
#1620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rephrase responseTimeout
Javadoc
#1620
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree that #readTimeout
would be a clearer name, as #responseTimeout
hints at "time to first byte" semantics.
reactor-netty-http/src/main/java/reactor/netty/http/client/HttpClient.java
Outdated
Show resolved
Hide resolved
Can you clarify what you mean with If you need idle timeout you need to consider connection pool's |
reactor-netty-http/src/main/java/reactor/netty/http/client/HttpClient.java
Outdated
Show resolved
Hide resolved
reactor-netty-http/src/main/java/reactor/netty/http/client/HttpClient.java
Outdated
Show resolved
Hide resolved
reactor-netty-http/src/main/java/reactor/netty/http/client/HttpClientRequest.java
Outdated
Show resolved
Hide resolved
reactor-netty-http/src/main/java/reactor/netty/http/client/HttpClient.java
Outdated
Show resolved
Hide resolved
reactor-netty-http/src/main/java/reactor/netty/http/client/HttpClient.java
Outdated
Show resolved
Hide resolved
reactor-netty-http/src/main/java/reactor/netty/http/client/HttpClient.java
Outdated
Show resolved
Hide resolved
reactor-netty-http/src/main/java/reactor/netty/http/client/HttpClientRequest.java
Outdated
Show resolved
Hide resolved
reactor-netty-http/src/main/java/reactor/netty/http/client/HttpClientRequest.java
Outdated
Show resolved
Hide resolved
reactor-netty-http/src/main/java/reactor/netty/http/client/HttpClientRequest.java
Outdated
Show resolved
Hide resolved
^ Similar to this question, after these changes, does it make sense to deprecate the |
Please open a new PR and let's discuss it there. |
Sure. Then, I take this as yes to my question. :) |
@reactor/netty-team PTAL |
reactor-netty-http/src/main/java/reactor/netty/http/client/HttpClient.java
Outdated
Show resolved
Hide resolved
reactor-netty-http/src/main/java/reactor/netty/http/client/HttpClientRequest.java
Outdated
Show resolved
Hide resolved
@hisener @Stephan202 Thanks for the discussion and the PR! |
@simonbasle Thanks for the review |
The
#responseTimeout
Javadoc and Netty'sReadTimeoutHandler
Javadoc don't seem to match.This PR tries to clarify the response timeout configuration.
Also, does it make sense to introduce
#readTimeout
and deprecate these methods as their name is misleading?