Closed
Description
Bug
Platform
Which player are you experiencing the problem on:
- iOS
Environment info
React native info output:
ERROR TypeError: undefined is not an object (evaluating '_reactNative.Image.propTypes.resizeMode')Library version: react-native@0.69.0-rc.6, react@18.1.0 and react-native-video@^5.2.0
Steps To Reproduce
Trying out all the latest stuff and I get the error shown above. I'm using nx & react-native without expo. The following code seems to be the culprit:
https://github.com/react-native-video/react-native-video/blob/master/Video.js#L429
Metadata
Metadata
Assignees
Type
Projects
Relationships
Participants
Activity
devon-whil commentedon Jun 10, 2022
A few other mentions of this same error:
#1672 (comment)
#2065 (comment)
devon-whil commentedon Jun 10, 2022
Here is the react-native commit that removed propTypes from the Image component:
facebook/react-native@3e229f2
freeboub commentedon Jun 10, 2022
@devon-whil thanks for the detail report !
Similar fix was done here: https://github.com/react-native-video/react-native-video/pull/2625/files
We should use:
import {ImagePropTypes} from 'deprecated-react-native-prop-types';
from:
https://www.npmjs.com/package/deprecated-react-native-prop-types/v/2.2.0
If you can open a PR that would be helpful !
Thank you
imshreyansh commentedon Jun 24, 2022
@hueniverse @devon-whil Is it fixed ? I am still facing the issue in React Native 0.69 !
Please help
freeboub commentedon Jun 24, 2022
@imshreyansh it is fixed in v6 pre release ? Are you one this one ?
imshreyansh commentedon Jun 24, 2022
@freeboub
Oops my mistake !! My package.json contained version "^5.2.0", I just upgraded the react native video to version "^6.0.0-alpha.1" and everything works absolutely fine.
Thanks :-)
Abhishek2250 commentedon Jun 27, 2022
I'm getting issues while installing the pods after upgrading the lib to version
6.0.0-alpha.1. When I degrade the lib to version5.2.0then it's working fine.SakeFabi commentedon Jul 1, 2022
I also ran into this, does it mean that I cannot use 6.0.0 for iOS? We definitely need both.
LeviWilliams commentedon Jul 5, 2022
Had issues installing 6.0.0-alpha.1 as well, had to enable
use_modular_headers!in my podfile as well as manually override it for glogpod 'glog', :podspec => '../node_modules/react-native/third-party-podspecs/glog.podspec', :modular_headers => falsekevinhylant commentedon Jul 6, 2022
Also running into this issue on 5.2.0 with RN 0.91.1 and react 18.0.0.
Any recommendations here?
JoshiAditi1993 commentedon Jul 15, 2022
Hi, I tried to upgrade to react 0.69.1 and react-native-video to 6.0.0-alpha.1. I am still facing this issue.
Please help
6 remaining items