-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Closed
Labels
topic: collectionrelated to the collection phaserelated to the collection phasetopic: configrelated to config handling, argument parsing and config filerelated to config handling, argument parsing and config filetype: backward compatibilitymight present some backward compatibility issues which should be carefully noted in the changelogmight present some backward compatibility issues which should be carefully noted in the changelogtype: deprecationfeature that will be removed in the futurefeature that will be removed in the futuretype: enhancementnew feature or API change, should be merged into features branchnew feature or API change, should be merged into features branchtype: feature-branchnew feature or API change, should be merged into features branchnew feature or API change, should be merged into features branch
Description
followup to #3044
plan and implement the deprecation time line for switching the default of empty_parameterset from skip to xfail(run=False)
over the course of the next few feature releases
Metadata
Metadata
Assignees
Labels
topic: collectionrelated to the collection phaserelated to the collection phasetopic: configrelated to config handling, argument parsing and config filerelated to config handling, argument parsing and config filetype: backward compatibilitymight present some backward compatibility issues which should be carefully noted in the changelogmight present some backward compatibility issues which should be carefully noted in the changelogtype: deprecationfeature that will be removed in the futurefeature that will be removed in the futuretype: enhancementnew feature or API change, should be merged into features branchnew feature or API change, should be merged into features branchtype: feature-branchnew feature or API change, should be merged into features branchnew feature or API change, should be merged into features branch
Type
Projects
Milestone
Relationships
Development
Select code repository
Activity
nicoddemus commentedon Jan 27, 2018
Not very nice of @pytestbot to remove labels like that... 😕
RonnyPfannschmidt commentedon Jan 29, 2018
lets see how it fares in future - @sils can you take a look on what prompted it and how it will learn
RonnyPfannschmidt commentedon Jan 29, 2018
closed by #3044
sils commentedon Jan 29, 2018
@RonnyPfannschmidt I'm fairly sure this is a race condition between you and the bot, I'm assuming you added the labels after opening the issue?
The bot uses the information from the webhook and doesn't always refresh because we can only use so many API requests.
We use locks internally to not have the bot do that to itself but then humans come around ;). I'll look into how we can improve on that, I think there is a way without wasting more API requests.
nicoddemus commentedon Jan 29, 2018
@sils you are right, @RonnyPfannschmidt updated the labels at 8:29 and the bot changed the labels at 8:30. 👍
sils commentedon Jan 29, 2018
I opened https://gitlab.com/gitmate/open-source/IGitt/issues/104 for this, thanks for pinging me :) keep doing that, the more feedback we get, the better.