Skip to content

plan and implement the change of empty_parameterset values #3155

@RonnyPfannschmidt

Description

@RonnyPfannschmidt
Member

followup to #3044

plan and implement the deprecation time line for switching the default of empty_parameterset from skip to xfail(run=False) over the course of the next few feature releases

Activity

added
type: feature-branchnew feature or API change, should be merged into features branch
type: deprecationfeature that will be removed in the future
type: backward compatibilitymight present some backward compatibility issues which should be carefully noted in the changelog
topic: configrelated to config handling, argument parsing and config file
on Jan 26, 2018
added
type: enhancementnew feature or API change, should be merged into features branch
and removed
topic: configrelated to config handling, argument parsing and config file
on Jan 26, 2018
added
topic: configrelated to config handling, argument parsing and config file
on Jan 27, 2018
nicoddemus

nicoddemus commented on Jan 27, 2018

@nicoddemus
Member

Not very nice of @pytestbot to remove labels like that... 😕

RonnyPfannschmidt

RonnyPfannschmidt commented on Jan 29, 2018

@RonnyPfannschmidt
MemberAuthor

lets see how it fares in future - @sils can you take a look on what prompted it and how it will learn

RonnyPfannschmidt

RonnyPfannschmidt commented on Jan 29, 2018

@RonnyPfannschmidt
MemberAuthor

closed by #3044

sils

sils commented on Jan 29, 2018

@sils

@RonnyPfannschmidt I'm fairly sure this is a race condition between you and the bot, I'm assuming you added the labels after opening the issue?

The bot uses the information from the webhook and doesn't always refresh because we can only use so many API requests.

We use locks internally to not have the bot do that to itself but then humans come around ;). I'll look into how we can improve on that, I think there is a way without wasting more API requests.

nicoddemus

nicoddemus commented on Jan 29, 2018

@nicoddemus
Member

@sils you are right, @RonnyPfannschmidt updated the labels at 8:29 and the bot changed the labels at 8:30. 👍

sils

sils commented on Jan 29, 2018

@sils

I opened https://gitlab.com/gitmate/open-source/IGitt/issues/104 for this, thanks for pinging me :) keep doing that, the more feedback we get, the better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    topic: collectionrelated to the collection phasetopic: configrelated to config handling, argument parsing and config filetype: backward compatibilitymight present some backward compatibility issues which should be carefully noted in the changelogtype: deprecationfeature that will be removed in the futuretype: enhancementnew feature or API change, should be merged into features branchtype: feature-branchnew feature or API change, should be merged into features branch

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @RonnyPfannschmidt@nicoddemus@sils@pytestbot

        Issue actions

          plan and implement the change of empty_parameterset values · Issue #3155 · pytest-dev/pytest