BF: fixed incorrect rect coordinates in bufferimagestim #3597
+4
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The problem turned out to be that we had a wrong coordinate mapping in Window._getFrame function fixes psychopyGH-3381 [psychopy#3381]
Codecov Report
@@ Coverage Diff @@
## release #3597 +/- ##
===========================================
- Coverage 43.13% 43.13% -0.01%
===========================================
Files 267 267
Lines 52626 52627 +1
Branches 9061 9062 +1
===========================================
Hits 22702 22702
Misses 27614 27614
- Partials 2310 2311 +1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem turned out to be that we had a wrong coordinate mapping in Window._getFrame function
fixes GH-3381 [https://github.com//issues/3381]