Ignore strict errors by @babel/parser
#11778
Merged
+67
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sosukesuzuki
commented
Nov 7, 2021
| @@ -1,4 +1,4 @@ | |||
| #### Fix errors on deleting variables (#11750 by @fisker) | |||
| #### Ignore errors for non-strict mode features (#11750 by @fisker, #11778 by @sosukesuzuki) | |||
There was a problem hiding this comment.
these features are not important so I think we don't need to add more code examples.
There was a problem hiding this comment.
Suggested change
| #### Ignore errors for non-strict mode features (#11750 by @fisker, #11778 by @sosukesuzuki) | |
| #### Ignore errors for sloppy mode syntax (#11750 by @fisker, #11778 by @sosukesuzuki) |
|
Are you sure this fixes #11777? |
fisker
reviewed
Nov 8, 2021
| @@ -0,0 +1 @@ | |||
| foo: function bar() {} | |||
There was a problem hiding this comment.
Let's name this file as labeled-function-declaration.js ? Or just labeled-function.js
There was a problem hiding this comment.
labeled-function-declaration.js sounds good
Woops. No. I mistook via GitHub Autocomplete. |
fisker
approved these changes
Nov 8, 2021
|
Wooooops, sorry I missed your suggestion.. |
4 tasks
|
You didn't, I added it few secondes ago. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #11753
Fixes #11754
Fixes #11755
Fixes #11756
Fixes #11758
Checklist
docs/directory).changelog_unreleased/*/XXXX.mdfile followingchangelog_unreleased/TEMPLATE.md.✨Try the playground for this PR✨