Skip to content

Fix @forward with formatting error #11683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 29, 2021
Merged

Fix @forward with formatting error #11683

merged 6 commits into from
Oct 29, 2021
+51 −0

Conversation

sriramarul
Copy link
Contributor

@sriramarul sriramarul commented Oct 14, 2021 •
edited by sosukesuzuki
Loading

Fixes #11636
Fixes #11598

sosukesuzuki
sosukesuzuki reviewed Oct 14, 2021
View reviewed changes
Copy link
Member

@sosukesuzuki sosukesuzuki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR!
The next time you create a PR in Prettier, please don't remove default PR descripiton.
Also, please add tests and changelog. Both can be found by reading CONTRIBUTING.md.

@sosukesuzuki sosukesuzuki changed the title Resolves #11636. Added null check for iPrevNode Fix @forward with formatting error Oct 29, 2021
Sriram Arul and others added 6 commits October 29, 2021 17:41
@sosukesuzuki
Resolves prettier#11636. Added null check for iPrevNode

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
54d72d4
@sosukesuzuki
undefined check
53454bd
@sosukesuzuki
Add changelog
2bb291a
@sosukesuzuki
Add tests
98e45a5
@sosukesuzuki
Update tests
f6c41f4
@sosukesuzuki
Update changelog
453ba07
@sosukesuzuki sosukesuzuki merged commit db0e9d2 into prettier:main Oct 29, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@fisker fisker

@sosukesuzuki sosukesuzuki

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BUG: Sass @forward with rules breaks parser Error thrown when formatting @forward ... with (...) block.
3 participants
@sriramarul @fisker @sosukesuzuki