fix parentheses around sequence expression as body of arrow chain #11593
+38
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sidebar: is there a reason #9992 is using const f = () => ({ k }) => k;it will get split across multiple lines, as in const f =
() =>
({ k }) =>
k;That seems obviously wrong to me; I'd be happy to submit a PR fixing it. |
|
@bakkot Have you seen #10955? I think we already have code for this prettier/src/language-js/print/function.js Line 343 in 20df210 |
|
@fisker I wrote that comment. And yes, the problem is that #9992 introduced a |
|
Sorry, I didn't see the description. I don't like coping the existing code, but seems hard to reuse? |
sosukesuzuki
approved these changes
Sep 27, 2021
Co-authored-by: Sosuke Suzuki <aosukeke@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #10955.
#9992 introduced a special case for printing the bodies of chained arrows, which has very different logic from printing a regular arrow. It neglected to copy over the logic to handle this case.
Checklist
changelog_unreleased/*/XXXX.mdfile followingchangelog_unreleased/TEMPLATE.md.✨Try the playground for this PR✨