-
Notifications
You must be signed in to change notification settings - Fork 440
Support ethereum accounts #560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Scratch all that... yes, on the ui-keyring it is actually the full thing. |
Nice, I'll PR that to ui-keyring now. |
I think it's good to go for a first look @jacogr The The accounts aren't injected in |
I have been ignoring this one, will get in after the update on Monday. Not sure why not injected, not a bad thing atm - I believe it is a keyring issue with the re-encoding. ... possibly. With that not-working, it still is a good idea to get it in, the issue is that we will probably break apps (apps === any user, not just the apps UI) when we start injecting these addresses. Not sure how to solve that, may need to deprecate the current accounts interface (or add a flag to it), to have some additional info coming along. Not sure. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Believe this is good to go - it works as-is, however users would need some additional effort (see the get(true)
changes to actually start using these.
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
closes #538