Skip to content

Support ethereum accounts #560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Dec 18, 2020
Merged

Support ethereum accounts #560

merged 18 commits into from
Dec 18, 2020

Conversation

Tbaut
Copy link
Contributor

@Tbaut Tbaut commented Dec 2, 2020

closes #538

  • Restore with JSON
  • Export JSON
  • Forget
  • Forbid derivation

ethereum

@Tbaut Tbaut added the WIP label Dec 2, 2020
@jacogr
Copy link
Member

jacogr commented Dec 2, 2020

That KeyringJson, as injected, is much simpler. It basically has the name & address, no other info. Have not looked at your hack....

... looked at your hack. So teh SubjectInfo there, you are actually correct, it still contains the full info. So you can adjust the type there. Only on injection does it actually get whittled down to the bare minimum.

Scratch all that... yes, on the ui-keyring it is actually the full thing.

@Tbaut
Copy link
Contributor Author

Tbaut commented Dec 2, 2020

Nice, I'll PR that to ui-keyring now.

Base automatically changed from tbaut-json-restore to master December 3, 2020 14:25
@Tbaut Tbaut removed the WIP label Dec 3, 2020
@Tbaut
Copy link
Contributor Author

Tbaut commented Dec 3, 2020

I think it's good to go for a first look @jacogr

The Address now accepts a new type prop. Based on this the address will be displayed with the ethereum encoding. If this is type is not supplied (in most cases) we'll check if we have this account in our Keyring.

The accounts aren't injected in apps, you may know why.

@jacogr
Copy link
Member

jacogr commented Dec 5, 2020

I have been ignoring this one, will get in after the update on Monday.

Not sure why not injected, not a bad thing atm - I believe it is a keyring issue with the re-encoding. ... possibly. With that not-working, it still is a good idea to get it in, the issue is that we will probably break apps (apps === any user, not just the apps UI) when we start injecting these addresses.

Not sure how to solve that, may need to deprecate the current accounts interface (or add a flag to it), to have some additional info coming along. Not sure.

@Tbaut
Copy link
Contributor Author

Tbaut commented Dec 18, 2020

Although the css for the image is a bit broad (img selector), it doesn't seem to break anything.
image

Copy link
Member

@jacogr jacogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Believe this is good to go - it works as-is, however users would need some additional effort (see the get(true) changes to actually start using these.

@Tbaut Tbaut merged commit 3c43132 into master Dec 18, 2020
@Tbaut Tbaut deleted the tbaut-support-ethereum branch December 18, 2020 10:44
@polkadot-js-bot
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@polkadot-js polkadot-js locked as resolved and limited conversation to collaborators May 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Ethereum account
4 participants