unify warning and error and add capslock warning #545
Merged
+130
−79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tbaut
commented
Nov 24, 2020
| border-radius: ${theme.borderRadius}; | ||
| border: 1px solid ${theme.inputBorderColor}; | ||
| border-color: ${withError ? theme.errorBorderColor : theme.inputBorderColor}; |
There was a problem hiding this comment.
This is the bug fix. The boder-color was overwritten by the more down the line "border".
Tbaut
commented
Nov 24, 2020
| @@ -64,10 +64,7 @@ function Export ({ className, match: { params: { address } } }: Props): React.Re | |||
| /> | |||
| <div className={className}> | |||
| <Address address={address}> | |||
| <Warning | |||
| className='movedWarning' | |||
| isDanger | |||
There was a problem hiding this comment.
This is a warning, not an error, removing the isDanger. The Button is still red.
Tbaut
commented
Nov 24, 2020
| @@ -40,10 +40,7 @@ function Forget ({ className, match: { params: { address } } }: Props): React.Re | |||
| /> | |||
| <div className={className}> | |||
| <Address address={address}> | |||
| <Warning | |||
| className='movedWarning' | |||
| isDanger | |||
There was a problem hiding this comment.
Same here, this is a warning, not an error, removing the isDanger. The Button is still red.
jacogr
reviewed
Nov 24, 2020
jacogr
reviewed
Nov 24, 2020
jacogr
reviewed
Nov 24, 2020
Co-authored-by: Jaco Greeff <jacogr@gmail.com>
Co-authored-by: Jaco Greeff <jacogr@gmail.com>
jacogr
approved these changes
Nov 25, 2020
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is how a warning + error looks like on signing
And here on the derivation flow
