Skip to content

Refactor password error in request pop up and remember checkbox #503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 20, 2020
Merged

Refactor password error in request pop up and remember checkbox #503

merged 3 commits into from
Oct 20, 2020
+76 −65

Conversation

Tbaut
Copy link
Contributor

@Tbaut Tbaut commented Oct 15, 2020 •
edited
Loading

closes #487
closes #494
closes #491

  • checkbox checked by default to extend the "password remember" period. Wording suggestion welcome :)
  • unchecking this checkbox will lock the account after this last signature (so it's either extend, or lock after this one)

Here is a demo

  • I first enter a wrong password twice, then type the right one and set to remember the password for 15min
  • submit another tx, the password isn't needed, the checkbox to extend is checked, I uncheck it
  • submit another tx -> password is asked.

remember

@Tbaut Tbaut added the WIP label Oct 15, 2020
@Tbaut Tbaut linked an issue Oct 15, 2020 that may be closed by this pull request
Show an explicit error message upon signing reuqest with wrong password #494
Closed
@Tbaut Tbaut removed the WIP label Oct 16, 2020
@Tbaut Tbaut changed the title Refactor request error and and remember checkbox Refactor password error in request pop up and remember checkbox Oct 17, 2020
jacogr
jacogr approved these changes Oct 20, 2020
View reviewed changes
Copy link
Member

@jacogr jacogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@jacogr jacogr merged commit 34e16c2 into master Oct 20, 2020
@jacogr jacogr deleted the tbaut-extend-15min branch October 20, 2020 14:34
@polkadot-js-bot
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@polkadot-js polkadot-js locked as resolved and limited conversation to collaborators Jun 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jacogr jacogr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@Tbaut @polkadot-js-bot @jacogr @actions-user