Skip to content

add "save event to calendar" functionality on calendar page #4068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 25, 2020
Merged

add "save event to calendar" functionality on calendar page #4068

merged 4 commits into from
Nov 25, 2020

Conversation

wirednkod
Copy link
Member

A small calendar icon is added to each event in order to allow user to download ics file and add it to calendar Screenshot 2020-11-25 at 12 12 02 AM

Partially verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
We cannot verify signatures from co-authors, and some of the co-authors attributed to this commit require their commits to be signed.
Copy link
Member

@jacogr jacogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks an absolute million for this - some small comments, but generally the functionality and look seems spot-on.

@wirednkod
Copy link
Member Author

Thanks an absolute million for this - some small comments, but generally the functionality and look seems spot-on.

Its a pleasure :) Thanks for the feedback

Copy link
Member

@jacogr jacogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Absolutely brilliant! I'll be making extensive use of this, as are others.

@jacogr jacogr merged commit 29b02c4 into polkadot-js:master Nov 25, 2020
@Swader
Copy link
Contributor

Swader commented Nov 25, 2020

@wirednkod this is great, can you let us know a DOT address? I'd like to tip you for this work.

@wirednkod
Copy link
Member Author

@Swader Thank you for the offer but there is really no need for a tip, mate. It was done for pleasure - rather than payment/tip. Was interested on having a look on the code for an interview with Parity and stumbled upon this one - seemed really easy and fast to create - so why not ¯_(ツ)_/¯

@wirednkod
Copy link
Member Author

@jacogr I have found various 3rd party npms that are making the export easier to download for Google/Apple/Outlook etc, etc. I could expand this feature to that - if you are ok with it :) Do you prefer custom code or 3rd parties are fine as well?

@Swader
Copy link
Contributor

Swader commented Nov 25, 2020

@Swader Thank you for the offer but there is really no need for a tip, mate. It was done for pleasure - rather than payment/tip. Was interested on having a look on the code for an interview with Parity and stumbled upon this one - seemed really easy and fast to create - so why not ¯_(ツ)_/¯

Admirable, but it's really commonplace: https://ipfs.io/ipns/polkadot.dotapps.io/#/treasury/tips - we really do like to support our supporters, especially since it's funded by the chain itself. If you change your mind, the offer stands, all I need is an address :)

@jacogr
Copy link
Member

jacogr commented Nov 25, 2020

Really depends on the value the npms actually add - if it is left-pad like, then I would rather bring it in via own-code.

Each dep ends up with having to be managed for the next 20 years and each bring in their level of cruft and so it just adds to the pile. Some weeks can't keep up with security advisories, so generally unless it is really novel work, try to steer clear from too many external deps, there are too many already bringing in their own pile...

Trying to clean up here as well, but current efforts in that regard actually sits in other repos, so will get here for "spring cleaning" :)

@wirednkod
Copy link
Member Author

Each dep ends up with having to be managed for the next 20 years and each bring in their level of cruft and so it just adds to the pile. Some weeks can't keep up with security advisories, so generally unless it is really novel work, try to steer clear from too many external deps, there are too many already bringing in their own pile...

Makes sense :) I'll have a look to wrap it in custom code in order to avoid dependencies. Cheers

@wirednkod
Copy link
Member Author

@Swader Thank you for the offer but there is really no need for a tip, mate. It was done for pleasure - rather than payment/tip. Was interested on having a look on the code for an interview with Parity and stumbled upon this one - seemed really easy and fast to create - so why not ¯_(ツ)_/¯

Admirable, but it's really commonplace: https://ipfs.io/ipns/polkadot.dotapps.io/#/treasury/tips - we really do like to support our supporters, especially since it's funded by the chain itself. If you change your mind, the offer stands, all I need is an address :)

Well.. if its a commonplace then here is an address:
11e2DNjBooKKoiXnt9Mw9ePi3PSDF9bUvh1ntYctAfUUoYD

Cheers

@polkadot-js-bot
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@polkadot-js polkadot-js locked as resolved and limited conversation to collaborators Jun 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants