Add keysAt & entriesAt #2746
Merged
Add keysAt & entriesAt #2746
+48
−34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacogr
commented
Oct 19, 2020
woss
pushed a commit
to woss/api
that referenced
this pull request
Apr 23, 2021
* At keysAt & entriesAt * Update packages/api/src/base/Decorate.ts
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2469
Especially for entriesAt, this PR leaves huge gaping hole - the metadata/types at that point is wrong. (Needs to be fixed here or before the next stable release, i.e. before it gets out in the wild)This is handled,isHistoricis set on the RPCs