Add a feature to make spin use optional #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks a lot! I didn't think about architectures without atomics when I added LockedHeap. Nice to hear that the crate is useful to you. |
|
There is now a version 0.5.0 on crates.io, which includes this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @phil-opp and thanks for your really useful crate!
I'm using it to create an allocator for a Cortex-M0.
Unfortunately the spin Mutex is not supported as it uses the sync AtomicBool which is not defined for this architecture.
So I've forked your repo to add a feature that make spin optional and if it's defined, it enables the LockedHeap. Thus, it is still compatible with other uses such as the one in https://github.com/pollen/alloc-cortex-m for instance where it uses its own Mutex to define a LockedHeap.
Let me know if you would be interested in integrating this.
Cheers!
Pierre