Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Refuse to start substrate without providing an explicit chain #7977

Merged
1 commit merged into from
Jan 25, 2021

Conversation

dvdplm
Copy link
Contributor

@dvdplm dvdplm commented Jan 25, 2021

Thank you for your Pull Request!

Before you submitting, please check that:

  • You added a brief description of the PR, e.g.:
    • What does it do?
    • What important points reviewers should know?
    • Is there something left for follow-up PRs?
  • You labeled the PR appropriately if you have permissions to do so:
    • A* for PR status (one required)
    • B* for changelog (one required)
    • C* for release notes (exactly one required)
    • D* for various implications/requirements
    • Github's project assignment
  • You mentioned a related issue if this PR related to it, e.g. Fixes #228 or Related #1337.
  • You asked any particular reviewers to review. If you aren't sure, start with GH suggestions.
  • Your PR adheres to the style guide
    • In particular, mind the maximal line length of 100 (120 in exceptional circumstances).
    • There is no commented code checked in unless necessary.
    • Any panickers have a proof or removed.
  • You bumped the runtime version if there are breaking changes in the runtime.
  • You updated any rustdocs which may have changed
  • Has the PR altered the external API or interfaces used by Polkadot? Do you have the corresponding Polkadot PR ready?

Refer to the contributing guide for details.

After you've read this notice feel free to remove it.
Thank you!

✄ -----------------------------------------------------------------------------

Sorry, something went wrong.

@github-actions github-actions bot added the A0-please_review Pull request needs code review. label Jan 25, 2021
@bkchr bkchr added B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Jan 25, 2021
@bkchr bkchr requested a review from shawntabrizi January 25, 2021 19:58
@shawntabrizi
Copy link
Member

bot merge

@ghost
Copy link

ghost commented Jan 25, 2021

Trying merge.

@ghost ghost merged commit 13cdf1c into master Jan 25, 2021
@ghost ghost deleted the dp-refuse-to-start-without-explicit-chain branch January 25, 2021 20:29
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants