This repository was archived by the owner on Nov 15, 2023. It is now read-only.
build: add nix shell #7376
Merged
build: add nix shell #7376
+23
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andresilva
added
A0-please_review
pepyakin
approved these changes
Oct 22, 2020
bkchr
approved these changes
Oct 22, 2020
|
I think it's ok to merge. First, I assume it's better to have this file than not and it's certainly not harmful. Second, since there are more than 1 nix user I am not worried that it gets out of touch. And, thirdly, if it ever gets unmaintained we can remove it easily. |
|
bot merge |
|
Trying merge. |
ghost
merged commit 
|
What is the consensus on flakes? Would anybody object turning this into a flake in the long term? |
|
@FlorianFranzen I haven't looked into flakes yet so I barely know how they work. I didn't know they could be used for shell definitions. |
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a nix shell definition with everything required to build substrate. I'm OK with this not getting merged but I think it's a nice-to-have for any potential nix users that might clone our repo.