Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

GeekCash reserve SS58 address id 19 #7195

Merged
merged 4 commits into from
Sep 29, 2020
Merged

Conversation

nasa8x
Copy link
Contributor

@nasa8x nasa8x commented Sep 24, 2020

Hello,

This PR adds a new ss58 address 19 for GeekCash network.

Thank you!

@cla-bot-2020
Copy link

cla-bot-2020 bot commented Sep 24, 2020

@nasa8x it looks like you have not signed our contributor license aggreement yet. Please visit this link to sign our agreement. This pull request cannot be merged until the agrement is signed.

@cla-bot-2020
Copy link

cla-bot-2020 bot commented Sep 24, 2020

@nasa8x, Your signature has been received.

Copy link
Member

@bkchr bkchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please also update the ss58registry.json file in the top level directory

@nasa8x
Copy link
Contributor Author

nasa8x commented Sep 25, 2020

I've updated. Thank you.

@nasa8x nasa8x requested a review from bkchr September 25, 2020 08:15
@bkchr bkchr added A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Sep 29, 2020
@bkchr
Copy link
Member

bkchr commented Sep 29, 2020

@nasa8x please merge master and after that I will merge the pr. Thank you

@nasa8x nasa8x requested a review from bkchr September 29, 2020 09:57
@bkchr bkchr merged commit 6379d14 into paritytech:master Sep 29, 2020
liuchengxu pushed a commit to liuchengxu/substrate that referenced this pull request Oct 5, 2020
* Add ss58 address for GeekCash

* Add ss58 address for GeekCash

* Add ss58 address for GeekCash on ss58registry.json
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants