Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Add support for Grandpa warp sync #2301

Merged
2 commits merged into from
Jan 21, 2021
Merged

Conversation

tomaka
Copy link
Contributor

@tomaka tomaka commented Jan 21, 2021

Builds upon paritytech/substrate#7711.

Ran cargo update -p sp-io and added a networking requests handler for Grandpa warp sync.

If there is no objection, I'd like to add this to Polkadot 0.7.28.
This purely adds new code paths, and the request-response system has an "integrated DoS protection mechanism" (proper flow control), so while this change might seem big in appearance, it's very low risk.

Verified

This commit was signed with the committer’s verified signature.
tomaka Pierre Krieger
@tomaka tomaka added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Jan 21, 2021
@tomaka tomaka requested review from andresilva and expenses January 21, 2021 17:27
@tomaka tomaka added this to the v0.8.28 milestone Jan 21, 2021

Verified

This commit was signed with the committer’s verified signature.
tomaka Pierre Krieger
Copy link
Contributor

@andresilva andresilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warp merge

@andresilva
Copy link
Contributor

bot merge

@ghost
Copy link

ghost commented Jan 21, 2021

Trying merge.

@ghost ghost merged commit 6f95a65 into paritytech:master Jan 21, 2021
@tomaka tomaka deleted the grandpa-warp-sync branch January 22, 2021 08:43
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants