This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Add Basic XCM #1934
Merged
Add Basic XCM #1934
+108
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
A3-in_progress
shawntabrizi
added
B0-silent
github-actions
bot
added
A0-please_review
pepyakin
reviewed
Nov 26, 2020
There was a problem hiding this comment.
A couple of changes requested.
The problem I see here is that the implementation of xcm sink doesn't account for any weight. Also, there is no guarantee on how much weight execution of a message can take and that's important.
I am not going to block on this, since XCM is a huge experiment anyway, but we should keep that in mind.
shawntabrizi
commented
Dec 2, 2020
pepyakin
force-pushed
the
shawntabrizi-xcm-sink
branch
from
e7a967b to
2e03494
Compare
pepyakin
force-pushed
the
shawntabrizi-xcm-sink
branch
from
2e03494 to
beeafc8
Compare
pepyakin
approved these changes
Dec 2, 2020
bkchr
approved these changes
Dec 14, 2020
|
bot merge |
|
Trying merge. |
ghost
merged commit
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a basic XCM Sink and enables the Relay Chain to pass downward XCM messages to Parachains.