Finalize ink! 3.0 integration #493
Merged
+1,388
−4,892
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This new codegen is based on the (also) new ink! IR.
…ctors Also this implementation avoids a lot of code duplication with the similar code generation for dispatch trait impl of ink! messages.
… impls This works even in precense of type aliases.
Codecov Report
@@ Coverage Diff @@
## master #493 +/- ##
==========================================
+ Coverage 62.42% 67.00% +4.57%
==========================================
Files 145 148 +3
Lines 6805 6300 -505
==========================================
- Hits 4248 4221 -27
+ Misses 2557 2079 -478
Continue to review full report at Codecov.
|
cmichi
reviewed
Sep 29, 2020
cmichi
reviewed
Sep 29, 2020
cmichi
reviewed
Sep 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finalization: ink! 3.0
This PR finalizes the implementation and integration of the new ink! 3.0.
ToDo List
mirifails forink_core'sbitstashunit tests. We should investigate why.ink_core::env::printlntodebug_printlnto make usage intent very clear.ink_core/envprovided hasheshash_bytesto hash some raw input byteshash_encodedto hash some SCALE encodable entity of typeTink_core/hashmodule and move all linkers to the above definitions.ink_langusing#[doc(hidden)]that are not user facing definitions but only required for the underlying code generation.scaleandscale-infointoink_langso that contract writers can simply use that one instead of having to depend on those crates directly themselves.cargo-contract newtemplate for the changes.cratesdirectory.ink_coreintoink_envandink_storagecrate. Maybe renameink_envtoink_runtime.ink_preludetoink_memory, mirroring the plannedink_storagecrate.ink_core/storage2->storageink_metadata/layout2->layoutink_coreAPI specific to this purpose.Env::Hash.topics[0]as the event's hashed signature if the ink! event is not anonymous.MAX_EVENT_TOPICSbut cannot distinguish between existing special-casedtopics[0]or not we need to make sure that non-anonymous events can actually only have up toMAX_EVENT_TOPICS - 1topics.README.md__ink_prefixed identifiers generically to be usable by all ink! language macros.#[ink::test]proc. macro to newerink_lang_irandink_lang_codegencrates.3.0.0.ink_lang_irandink_lang_codegencrates fromink_lang_macro. (Part 3)