Migrate examples to new APIs #487
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is an example of a code snippet which would get more complicated using the new Entry API: https://github.com/paritytech/ink/blob/d4df4e7ebadc449fc6d63cebb115d546d3b57ca5/examples/erc721/lib.rs#L266-L274. |
Codecov Report
@@ Coverage Diff @@
## master #487 +/- ##
===========================================
- Coverage 80.11% 66.03% -14.08%
===========================================
Files 142 142
Lines 6230 6230
===========================================
- Hits 4991 4114 -877
- Misses 1239 2116 +877
Continue to review full report at Codecov.
|
Robbepop
requested changes
Sep 21, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #485
Left these two ToDos out:
There are no examples which could use
Vec::set()orVec::clear()at the moment.The method is
unsafeand we try to use onlyunsafein examples when it's strictly necessary.In terms of the new HashMap Entry API there are more places where we could use them ‒ at the cost of readability though.