when error occurs,it do not report error span #14

wuyupengwoaini · 2018-10-19T09:32:15Z

java-redis-client/opentracing-redis-spring/src/main/java/io/opentracing/contrib/redis/spring/connection/RedisTracingUtils.java

Lines 40 to 46 in 784e55d

    
           static <T> T doInScope(String command, Supplier<T> supplier, boolean withActiveSpanOnly, 
        
               Tracer tracer) { 
        
             try (Scope ignored = 
        
                 RedisTracingUtils.buildScope(REDIS_COMMAND, command, withActiveSpanOnly, tracer)) { 
        
               return supplier.get(); 
        
             } 
        
           }

Signed-off-by: Sergei Malafeev <sergeymalafeev@gmail.com>

malafeev · 2018-10-19T10:12:49Z

fixed, will be available in version 0.0.10 (during 24 hours)

wuyupengwoaini · 2018-10-22T05:57:17Z

thanks for fixed this problem.But,today i found jdbc instrument has the same problem.I suppose that it is a good idea to check other instrument like hytrix and so on

malafeev self-assigned this Oct 19, 2018

malafeev mentioned this issue Oct 19, 2018

report error span when error occurs #15

Merged

malafeev added a commit that referenced this issue Oct 19, 2018

#14 report error span when error occurs (#15)

3604439

malafeev closed this as completed Oct 19, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

when error occurs,it do not report error span #14

when error occurs,it do not report error span #14

wuyupengwoaini commented Oct 19, 2018

malafeev commented Oct 19, 2018

wuyupengwoaini commented Oct 22, 2018 •

edited

Loading

when error occurs,it do not report error span #14

when error occurs,it do not report error span #14

Comments

wuyupengwoaini commented Oct 19, 2018

malafeev commented Oct 19, 2018

wuyupengwoaini commented Oct 22, 2018 • edited Loading

wuyupengwoaini commented Oct 22, 2018 •

edited

Loading