Skip to content

when error occurs,it do not report error span #14

New issue
New issue
Closed
Closed
when error occurs,it do not report error span#14
Assignees
malafeev
@wuyupengwoaini

Description

@wuyupengwoaini
wuyupengwoaini
opened on Oct 19, 2018

java-redis-client/opentracing-redis-spring/src/main/java/io/opentracing/contrib/redis/spring/connection/RedisTracingUtils.java

Lines 40 to 46 in 784e55d

static <T> T doInScope(String command, Supplier<T> supplier, boolean withActiveSpanOnly,
Tracer tracer) {
try (Scope ignored =
RedisTracingUtils.buildScope(REDIS_COMMAND, command, withActiveSpanOnly, tracer)) {
return supplier.get();
}
}

Activity

malafeev
self-assigned this
on Oct 19, 2018
malafeev
added a commit that references this issue on Oct 19, 2018

#14 report error span when error occurs

8b47540
malafeev
mentioned this on Oct 19, 2018
malafeev
added a commit that references this issue on Oct 19, 2018

#14 report error span when error occurs (#15)

3604439
malafeev

malafeev commented on Oct 19, 2018

@malafeev
malafeev
on Oct 19, 2018

fixed, will be available in version 0.0.10 (during 24 hours)

malafeev
closed this as completedon Oct 19, 2018
wuyupengwoaini

wuyupengwoaini commented on Oct 22, 2018

@wuyupengwoaini
wuyupengwoaini
on Oct 22, 2018 · edited by wuyupengwoaini
Author

thanks for fixed this problem.But,today i found jdbc instrument has the same problem.I suppose that it is a good idea to check other instrument like hytrix and so on

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

    Development

    No branches or pull requests

      Participants

      @malafeev@wuyupengwoaini

      Issue actions
        when error occurs,it do not report error span · Issue #14 · opentracing-contrib/java-redis-client