Skip to content

Draw lines from <bracket> (XML) #940

New issue
New issue
Open
Open
Draw lines from <bracket> (XML)#940
Labels
feature
@floka94

Description

@floka94
floka94
opened on Jan 17, 2021

OSMD does not support to add lines below or above the notes. See this example:

image

In MusicXML i can draw such lines with the following tag:
Start of a line:

      <direction placement="below">
        <direction-type>
          <bracket type="start" number="1" line-end="none" line-type="solid" default-y="-69.20"/>
          </direction-type>
        </direction>

End of a line:

      <direction placement="below">
        <direction-type>
          <bracket type="stop" number="1" line-end="none"/>
          </direction-type>
        </direction>

Is this feature planned, or still not possiple to add because vexflow does not support this?

Activity

sschmidTU

sschmidTU commented on Jan 17, 2021

@sschmidTU
sschmidTU
on Jan 17, 2021
Contributor

Vexflow does support this, there's already a method in OSMD to draw lines:

osmd.Drawer.DrawOverlayLine(start: PointF2D, stop: PointF2D, musicPage: GraphicalMusicPage,
                           color: string = "#FF0000FF", lineWidth: number = 0.2)

image
details here:
#651 (comment)

But i assume you want to have the lines drawn from XML via the bracket tag. That is currently not yet supported.

sschmidTU
added
feature
on Jan 17, 2021
floka94

floka94 commented on Jan 17, 2021

@floka94
floka94
on Jan 17, 2021
Author

Yes you are right, i want to have the lines drawn from XML. But nice to know that there is already a method implemented to draw a simple line. Maybe i wil try to implement this feature.

sschmidTU

sschmidTU commented on Jan 17, 2021

@sschmidTU
sschmidTU
on Jan 17, 2021
Contributor

If we would do this in OSMD, which would be nice, we'd have to respect and afterwards update the Skyline or Bottomline. (SkyBottomLine)

sschmidTU
mentioned this on Jan 19, 2021
sschmidTU
changed the title [-]Add feature to draw lines[/-] [+]Draw lines from <bracket> (XML)[/+] on Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    feature

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @floka94@sschmidTU

        Issue actions
          Draw lines from <bracket> (XML) · Issue #940 · opensheetmusicdisplay/opensheetmusicdisplay