You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Nov 6, 2022. It is now read-only.
I indeed see the whitespace before the colon, but still not sure what kind of failure you are experiencing. From what I have tried a week ago, it really looked like http-parser supports whitespace before the colon.
Activity
indutny commentedon Apr 5, 2016
I believe http-parser will fail only in a strict mode. May I ask you to share more details with us?
chenzhiwei commentedon Apr 5, 2016
When the http response header is something like this:
Please pay attention to the white spaces after
Content-Length
and before the colon.I encountered this error in Mesos project: apache/mesos@b2c92ee#diff-cce67628b066393859924dbdfc3e0fb5L658
The bug URL: https://issues.apache.org/jira/browse/MESOS-5063
indutny commentedon Apr 5, 2016
I indeed see the whitespace before the colon, but still not sure what kind of failure you are experiencing. From what I have tried a week ago, it really looked like http-parser supports whitespace before the colon.
May I ask you help me understand it?
chenzhiwei commentedon Apr 5, 2016
Yes, I thought http-parser 2.6.2 solved this issue, but actually not.
You can insert a white space in this line, then do a make action, it will show you errors.
https://github.com/nodejs/http-parser/blob/v2.6.2/test.c#L1172
chenzhiwei commentedon Apr 5, 2016
More detailed:
The
parsed
and the reallength
are not same.chenzhiwei commentedon Apr 7, 2016
@indutny Could you take a look about this issue? Thanks.
chenzhiwei commentedon Apr 13, 2016
Set the
HTTP_PARSER_STRICT=0
solved my issue, thanks.