Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ios13.4 is not working,How to solve!!! #2191

Open
scandalYang opened this issue Mar 26, 2020 · 19 comments · May be fixed by #2684
Open

Ios13.4 is not working,How to solve!!! #2191

scandalYang opened this issue Mar 26, 2020 · 19 comments · May be fixed by #2684

Comments

@scandalYang
Copy link

scandalYang commented Mar 26, 2020

No description provided.

@scandalYang
Copy link
Author

change rc.4 can work

@TuffyLiu
Copy link

TuffyLiu commented Mar 26, 2020

it can't work in Wechat Browser on ios 13.4
but it can work in Safari

then I fork the project
bebug......
found that one line of code isn't valid
...no return ...no erro

// src/dom/document-cloner.ts
//  line 96
if (documentClone.fonts && documentClone.fonts.ready) {
       // await documentClone.fonts.ready;
 }

I delete it
because i didn't use web font

it's work!!!

then i create a branch to use this

https://github.com/TuffyLiu/html2canvas/releases

you can add this to your project package.json, if you you need....
"html2canvas": "git+https://github.com/TuffyLiu/html2canvas.git#1.0.0-rc.6",''

your guys has any good solution?

@shezhangzhang
Copy link

it can't work in Wechat Browser on ios 13.4
but it can work in Safari

then I fork the project
bebug......
found that one line of code isn't valid
...no return ...no erro

// src/dom/document-cloner.ts
//  line 96
if (documentClone.fonts && documentClone.fonts.ready) {
       // await documentClone.fonts.ready;
 }

I delete it
because i didn't use web font

it's work!!!

then i create a branch to use this

https://github.com/TuffyLiu/html2canvas/releases

you can add this to your project package.json, if you you need....
"html2canvas": "git+https://github.com/TuffyLiu/html2canvas.git#1.0.0-rc.6",''

your guys has any good solution?

use "rc.4" can solve this problem.

@TuffyLiu
Copy link

it can't work in Wechat Browser on ios 13.4
but it can work in Safari
then I fork the project
bebug......
found that one line of code isn't valid
...no return ...no erro

// src/dom/document-cloner.ts
//  line 96
if (documentClone.fonts && documentClone.fonts.ready) {
       // await documentClone.fonts.ready;
 }

I delete it
because i didn't use web font
it's work!!!
then i create a branch to use this
https://github.com/TuffyLiu/html2canvas/releases
you can add this to your project package.json, if you you need....
"html2canvas": "git+https://github.com/TuffyLiu/html2canvas.git#1.0.0-rc.6",''
your guys has any good solution?

use "rc.4" can solve this problem.

it's not working~~

@Guohjia
Copy link

Guohjia commented Mar 29, 2020

yes,use "rc.4" can solve this problem

@mjbernardo-30
Copy link

Currently using rc 4 but it doesn't work

@StubbornG
Copy link

StubbornG commented Apr 2, 2020

当前使用RC 4,但不起作用

I'll go back to RC4. That'll do. Forgot to delete package. json ^ , always downloading RC5.

@JDEast1029
Copy link

JDEast1029 commented Apr 8, 2020

what do u guys mean by "rc.4" for? And where can i get that?

package version; "html2canvas": "^1.0.0-rc.5"

@StubbornG
Copy link

StubbornG commented Apr 8, 2020 via email

@StubbornG
Copy link

StubbornG commented Apr 8, 2020 via email

@davy-gan
Copy link

使用 rc.4不能加载字体文件 导致字体图标都不能显示

@davy-gan
Copy link

81586785055_ pic
91586785116_ pic_hd
在开发工具上可以正常显示 但是 在手机浏览器上 字体显示失败,文字还缩到一起去了

@lwpassvoice
Copy link

+++1

@supersuc
Copy link

+1 !!!

@weituotian
Copy link

@niklasvh need help!!!

@syunc
Copy link

syunc commented Oct 12, 2020

actually use rc.4 can't work well for me, it's better perform in rc.1 or rc.2 on wechat

@niklasvh
Copy link
Owner

Is this still an issue?

@real-jacket real-jacket linked a pull request Aug 28, 2021 that will close this issue
@huzedong2015
Copy link

+1

@jesusslim
Copy link

It worked, @niklasvh maybe make this line optional in next version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

16 participants