Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash when backPress from SettingsActivity after Orientation changed #585

Closed
frogoscar opened this issue Aug 10, 2016 · 2 comments
Closed
Labels

Comments

@frogoscar
Copy link

DESCRIPTION

QKSMS crashes when pressing Back button from Settings Activity after Orientation change.
This bug happens both in version on Google Play and built from Github.
It only happens when rotating screen in Category (Appearance, General, Notifications, MMS, QK Reply, etc. ) of Settings.

STEPS

  1. Start QKSMS
  2. Go to Settings by clicking on the OptionMenu -> Settings
  3. Click on one Category in the list
  4. When you are in the Category (for example, General), rotate the screen
  5. After screen rotation, it will return to main Settings screen automatically (which is also not good)
  6. Click on Back button

EXPECTED

Return to the Conversations Activity which contains the conversation list.

OBSERVATIONS

Crashes.

Logcat from Android Studio

FATAL EXCEPTION: main
Process: com.moez.QKSMS, PID: 22003
java.lang.IllegalStateException: Fragment already added: SettingsFragment{1d41d5f0 #0 id=0x7f0e0085 SettingsFragment}
at android.app.FragmentManagerImpl.addFragment(FragmentManager.java:1153)
at android.app.BackStackRecord.popFromBackStack(BackStackRecord.java:1547)
@frogoscar
Copy link
Author

frogoscar commented Aug 10, 2016

I create a patch which corrects this issue (also the bad behavior : After screen rotation, it will return to main Settings screen automatically).

Please try it and decide what to do about this issue. Maybe you can come out with a better solution.

Thank you very much. I love QKSMS. It is great!

PS: Github does not permit to attach patch file, so I rename it with addition of ".txt" in the end.

0001-Fix-crash-when-backPress-from-SettingsActivity-after.patch.txt

@xiaochunlee
Copy link

Good sharing!thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants