Same thing in Svelte files here

Same for me, also using Vue (Volar) extension.
Disabling organizeImports works as a temporary fix.

It seems like the combination of these two settings causes to editor to save files in an endless loop:

"editor.codeActionsOnSave": ["source.organizeImports", "source.fixAll.eslint"],

@Zertz In my case, I have (or had before removing "source.organizeImports"):

"editor.codeActionsOnSave": {
  "source.organizeImports": true,
  "source.sortImports": true,
  "source.fixAll.markdownlint": true,
  "source.fixAll": true
}

Does this reproduce with all extensions disabled? Sounds like it's likely caused by an extension

No, it doesn't, but it still seems like a regression in VSCode 🤔 I'm using eslint like this person, i.e. also with "editor.codeActionsOnSave": ["source.organizeImports", "source.fixAll.eslint"],. vscode-eslint hasn't updated since July

In my case if I have an import statement like

import {
    makeStoreClosureEventId,
    parseStoreClosureEventId,
    StoreClosureEventIdType,
    validateStoreClosureEventId,
} from '@root/gql/types/StoreClosureEvent'

the organize imports step will remove the trailing comma and then eslint fixAll adds it back again. But instead of doing that just once, it now happens in a continuous loop

Due to source.organizeImports not respecting trailing commas ( #98123 - unresolved), I also use source.fixAll.eslint to fix it. However, the latest release cycles repeatedly.

Sounds like it's likely caused by an extension

@mjbvz Even if that's the case, this doesn't happen on previous VSCode versions.

This also happens for me. I haven't changed my extension setup since before the last VSCode update. Even if an extension is involved in this, merely updating VSCode shouldn't be causing this. It also happens if I disable ESLint in the save actions.

Same here on react-native project, it crashes vscode

"editor.codeActionsOnSave": [
  "source.formatDocument",
  "source.organizeImports",
  "source.fixAll"
],

Same here with the vshaxe extension. I only had source.organizeImports in my codeActionsOnSave.

Same issue using the Astro framework and its language support extension.

Perhaps this issue might have something to do with the recent changes here: #164035 ?

Same issue with Astro

After I turned off 'source.organizeImports' it was fine

Same issue here, infinite organize import loop with flickering of import statements. I downgraded to version 1.72.2 for now. Hopefully this can be fixed.

If anyone is here still trying to fix, try do it under workspace settings instead of user settings, fixed the issue for me.

For me it's still glitching with this config:

"editor.codeActionsOnSave": ["source.fixAll.format", "source.fixAll.eslint"]
"editor.defaultFormatter": "esbenp.prettier-vscode"

I had to downgrade to make it work again.

Couple of observations and ways to fix this

• Save participation should be re-entrant - that's likely a bigger task for recovery (fyi @bpasero)
• The code action save participant should apply any workspace edit with the "ignore auto save"-flag (which already exists)
• We can revert the commit that introduced this (tho, that was done for a reason...)

I am still experiencing this problem for python files. What is the resolution?

Version: 1.73.0
Commit: 8fa188b
Date: 2022-11-01T15:38:50.881Z
Electron: 19.0.17
Chromium: 102.0.5005.167
Node.js: 16.14.2
V8: 10.2.154.15-electron.0
OS: Darwin x64 21.6.0
Sandboxed: No

This will ship with 1.73.1

Thank you very much for the speeeeeedy action 🚀