Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add Git Bash(WOW64) to ThirdPartyToolProfiles #5141

Merged
merged 4 commits into from Mar 27, 2020
Merged

doc: add Git Bash(WOW64) to ThirdPartyToolProfiles #5141

merged 4 commits into from Mar 27, 2020

Conversation

skyline75489
Copy link
Collaborator

Summary of the Pull Request

Added Git Bash (WOW64) profile.

References

PR Checklist

  • Closes #xxx
  • CLA signed. If not, go over here and sign the CLA
  • Tests added/passed
  • Requires documentation to be updated
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Detailed Description of the Pull Request / Additional comments

The mingw32 part is a catch.

Validation Steps Performed

@skyline75489 skyline75489 mentioned this pull request Mar 27, 2020
Closed
2 tasks
@zadjii-msft zadjii-msft added Area-Settings Issues related to settings and customizability, for console or terminal Issue-Docs It's a documentation issue that really should be on MicrosoftDocs/Console-Docs Needs-Second It's a PR that needs another sign-off Product-Terminal The new Windows Terminal. labels Mar 27, 2020
DHowett-MSFT
DHowett-MSFT suggested changes Mar 27, 2020
View reviewed changes
doc/user-docs/ThirdPartyToolProfiles.md Outdated Show resolved Hide resolved
doc/user-docs/ThirdPartyToolProfiles.md Outdated Show resolved Hide resolved
@ghost ghost added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Mar 27, 2020
@DHowett-MSFT DHowett-MSFT mentioned this pull request Mar 27, 2020
Closed
@skyline75489 @DHowett
Update doc/user-docs/ThirdPartyToolProfiles.md
3b069e8 
Co-Authored-By: Dustin L. Howett (MSFT) <duhowett@microsoft.com>
@ghost ghost removed the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Mar 27, 2020
skyline75489 and others added 2 commits March 28, 2020 06:57
@skyline75489 @DHowett
Update doc/user-docs/ThirdPartyToolProfiles.md
d62f995 
Co-Authored-By: Dustin L. Howett (MSFT) <duhowett@microsoft.com>
@skyline75489
Update ThirdPartyToolProfiles.md
422ec06
DHowett-MSFT
DHowett-MSFT approved these changes Mar 27, 2020
View reviewed changes
Copy link
Contributor

@DHowett-MSFT DHowett-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@DHowett-MSFT DHowett-MSFT merged commit 91b84f1 into microsoft:master Mar 27, 2020
@skyline75489 skyline75489 deleted the patch-1 branch January 25, 2021 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DHowett-MSFT DHowett-MSFT DHowett-MSFT approved these changes

@zadjii-msft zadjii-msft zadjii-msft approved these changes

@miniksa miniksa Awaiting requested review from miniksa

@carlos-zamora carlos-zamora Awaiting requested review from carlos-zamora

@leonMSFT leonMSFT Awaiting requested review from leonMSFT

Assignees
No one assigned
Labels
Area-Settings Issues related to settings and customizability, for console or terminal Issue-Docs It's a documentation issue that really should be on MicrosoftDocs/Console-Docs Needs-Second It's a PR that needs another sign-off Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@skyline75489 @DHowett-MSFT @zadjii-msft