Changing yellow color and brightness did not work for me #106

Closed

Closed

Changing yellow color and brightness did not work for me#106

Assignees

Labels

In home.dart, change the brightness to dark
in login.dart, change the primary override to yellow for both text fields
When I did that it had no effect.
https://github.com/benedicte69/flutter_mdc_100_series

added

on Aug 24, 2018

assigned

on Aug 24, 2018

mentioned this

on Aug 30, 2018

[106] Changed "PrimaryColorOverride" to "AccentColorOverride" #114

Contributor

Hi there, thanks for spotting this! The issue comes from the PrimaryColorOverride in login.dart. We're using primaryColor when we should be using accentColor.

I'm working on updating the code and docs, in the meantime, all you need to get it working is to change primaryColor to accentColor in the build method of PrimaryColorOverride.

See pull 114 for more info.

Contributor

Codelab has been updated, as well as the code itself, to override the accentColor instead of the primaryColor. Thanks again for spotting this!

closed this as completed

on Aug 31, 2018

Author

Hello MH Johnson, Thank you for helping me but it is still not working, it seems impossible to override the first theme, am I forgetting to do something in app.dart? Le jeudi 30 août 2018 à 19:21:56 UTC+2, MH Johnson <notifications@github.com> a écrit : Hi there, thanks for spotting this! The issue comes from the PrimaryColorOverride in login.dart. We're using primaryColor when we should be using accentColor. I'm working on updating the code and docs, in the meantime, all you need to get it working is to change primaryColor to accentColor in the build method of PrimaryColorOverride. See pull 114 for more info. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

Author

Thanks, but it is still not working even with accentColor, it seems impossible to override the first theme, am I forgetting to do something in app.dart? Le lundi 3 septembre 2018 à 17:21:21 UTC+2, Benedicte <notifications@github.com> a écrit : Hello MH Johnson, Thank you for helping me but it is still not working, it seems impossible to override the first theme, am I forgetting to do something in app.dart? Le jeudi 30 août 2018 à 19:21:56 UTC+2, MH Johnson <notifications@github.com> a écrit : Hi there, thanks for spotting this! The issue comes from the PrimaryColorOverride in login.dart. We're using primaryColor when we should be using accentColor. I'm working on updating the code and docs, in the meantime, all you need to get it working is to change primaryColor to accentColor in the build method of PrimaryColorOverride. See pull 114 for more info. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

Contributor

Hi,

I tried cloning your repo at your latest commit, and I was actually able to get it working as intended. Just to clarify, what we are overriding is the color of the text field outline, only after the text field has been selected.

Hope this helps, let me know if you have any more questions.

Author

Hello, Thank you for having taken the time to look at my GitHub. I have a last concerned, if I am using theme 01 the overriding does not work, if I am using theme 02, the overriding works. I have renamed the themes to clarify the situation but do not understand why it is only working if I am using theme number 02. Perhaps You can tell me. Thanks in advance.

Contributor

Hm, I can't actually figure out what's going on. My original fix actually was not complete. It turns out that when our ThemeData (in app.dart) uses the ThemeData.light() theme as a base, the TextField border color is determined by primaryColor. But when we use the ThemeData.dark() theme as a base, the border color is determined by accentColor.

@willlarche do you happen to know why this is?

reopened this

self-assigned this

Collaborator

Don't know why this is but accept that it is :) We've updated the code to use accentColor. Should be good to go.

Author

It would be great to understand why too :) as very often I read some post such as:' when I make some change in Flutter, it does not display...' Clarifying the situation on where and how things are allocated could certainly solve some issues. Le lundi 10 septembre 2018 à 17:11:47 UTC+2, Will Larche <notifications@github.com> a écrit : Don't know why this is but accept that it is :) We've updated the code to use accentColor. Should be good to go. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

Collaborator

Oh, this isn't a case of technical mystery. If you follow the calls, you can find the code. https://github.com/flutter/flutter/blob/fc1b304326214296ac02bddfed9396e2a716e63d/packages/flutter/lib/src/material/input_decorator.dart#L1588

The mystery is why that logic is how it is. This was long before we had a Material Theming spec. So, the Flutter team had to make decisions. And they did a really great job. Material Theming ended up having different rules for text inputs but it came years later.

closed this as completed

on Sep 11, 2018

mentioned this

on Sep 16, 2018

MDC-103 - Codelabs page - Step 5 - overriding accentColor doesn't work #128

to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Participants