Skip to content

Fwd: *emphasis* & **strong** markups not working with symbol chars at the inner closing end #410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Vdragon opened this issue Nov 30, 2017 · 2 comments
Closed

Fwd: *emphasis* & **strong** markups not working with symbol chars at the inner closing end #410

Vdragon opened this issue Nov 30, 2017 · 2 comments

Comments

@Vdragon
Copy link

Vdragon commented Nov 30, 2017 •
edited
Loading

(Forwarded from *emphasis* & **strong emphasis** markup not working under certain circumstances · Issue #459 · hackmdio/hackmd)

This issue can be reproduced when:

  • A symbol_character is not at the end of the markup(symbol_character can either English or Chinese punctuation character, like colon:： and period.。)

AND

  • Space character is not immediately after the markup

demo
@Vdragon Vdragon mentioned this issue Nov 30, 2017
Closed
@Vdragon Vdragon changed the title Fwd: *emphasis* & **strong emphasis** markup not working with symbol chars at the closing end Fwd: *emphasis* & **strong emphasis** markup not working with symbol chars at the inner closing end Nov 30, 2017
@Vdragon Vdragon changed the title Fwd: *emphasis* & **strong emphasis** markup not working with symbol chars at the inner closing end Fwd: *emphasis* & **strong** markups not working with symbol chars at the inner closing end Nov 30, 2017
@puzrin
Copy link
Member

puzrin commented Nov 30, 2017

That works exactly as defined in commonmark spec, see reference implementation.

That's not a bug of this package. It's better ask at commonmark forum about known issues with asian languages group and their plains. As soon as spec will be changed, we will update logic too. But we can not diverge from spec in advance.

@puzrin puzrin closed this as completed Nov 30, 2017
@guanpengchn guanpengchn mentioned this issue Oct 15, 2019
Closed
@guanpengchn guanpengchn mentioned this issue Mar 22, 2020
Open
This was referenced Oct 25, 2020
Closed
Closed
Closed
Closed
@Mrcxt Mrcxt mentioned this issue Jun 11, 2021
Open
@Mrcxt Mrcxt mentioned this issue Jun 24, 2021
Open
@tats-u
Copy link

tats-u commented Jan 26, 2025

Tentative solution: https://www.npmjs.com/package/markdown-it-cjk-friendly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@puzrin @Vdragon @tats-u