New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cyclic dependency error #20
Comments
Not much changed in terms of environment that this is ran in, hence pinpointing it down to latest release |
+1 |
1 similar comment
+1 |
For me too - the fix on my side was to downgrade the version of toposort to 1.0.4. I didn't actually reference this dependency directly - webpack does - just fyi. |
+1 |
@seanlandsman I think webpack is whats failing us as well, how did you downgrade toposort for it specifically? Never did it before for specific packages, would be cool to know :) |
I'm using yarn, and added this to my package.json:
|
|
+1 - affects html webpack plugin |
+1 |
1 similar comment
+1 |
We're also hitting this. :( |
+1 not too happy, respect semver! :( |
@iljadaderko I added this to package.json "toposort":"1.0.4" thanks |
+1 |
2 similar comments
+1 |
+1 |
I'm so sorry folks. v1.0.6 is out now, which reverts #19 |
+1 |
Thanks for quick turnaround! |
thanks for the quick fix. Our production build failed yesterday since it's the dependency of html-webpack-plugin |
UPDATE: there's a workaround provided in jantimon/html-webpack-plugin#870 which is working for me at the moment. I'm leaving this comment up in case anybody else is affected. I'm currently hitting this error in 1.0.6 too (through
I made a new and clean repo to try and reproduce it but wasn't able to:
Any help will be appreciated. Full error dump:
|
Reproduction in case anyone needs it. Error is thrown when building angular app in AoT mode. |
Sorry for my absence. Can you reproduce this with toposort only? Alternatively, what does the dependency graph look like? |
So, when I run the build script for the reproduction repo, I get the following edges of the dependency graph:
Clearly, there is a cyclic dependency between 5005 and 5004. The only "bug" in toposort, is the type error, if you will, which I'll fix now. :) |
@WiseBird I found that error happiness if html-webpack-plugin uses default chunksSortMode parameter.
Or use your special function. For example:
|
@sumbad do you mean that this cyclic dependency error does not occur when Should we open an HtmlWebpackPlugin issue? |
@laurentpayot there already is one: jantimon/html-webpack-plugin#870 ;) |
厉害了我的哥 |
I also get this error without specifying |
i'm seeing this error with 1.0.7 in a dojo project
change |
yes, change to chucksSortMode to none in webpack config file fixes it |
Latest release causes:
Let me know if you need more information ;)
The text was updated successfully, but these errors were encountered: