Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove resync period for sset controller #75622

Merged
merged 1 commit into from Apr 4, 2019
Merged

Remove resync period for sset controller #75622

merged 1 commit into from Apr 4, 2019

Conversation

anyasabo
Copy link

@anyasabo anyasabo commented Mar 23, 2019 •
edited

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
The stateful set controller is resyncing all ssets every 30 seconds, As discussed in the linked issue, this is not necessary, and can cause delays processing actual updates when large amounts of ssets exist.

Which issue(s) this PR fixes:
Fixes #75495

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

StatefulSet controllers no longer force a resync every 30 seconds when nothing has changed.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Mar 23, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @jonsabo. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 23, 2019
@anyasabo
Copy link
Author

/sig apps

@k8s-ci-robot k8s-ci-robot added sig/apps Categorizes an issue or PR as relevant to SIG Apps. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 23, 2019
@likakuli
Copy link
Contributor

@jonsabo The default SharedInformerFactory has a default resync period, if not set in the config file, it will be 12 * Hous ~ 2 * 12 * Hours, so the statefulset still will have the probelem when use the default resync period

@anyasabo
Copy link
Author

That seems like that might be acceptable, a quick scan looks like deployments, daemonsets, and replicasets do not explicitly set a resync

@anyasabo
Copy link
Author

/assign @enisoc @kow3ns @janetkuo

@enisoc
Copy link
Member

enisoc commented Apr 3, 2019

/ok-to-test
/approve

I suggest adding a bit more detail in the release note:

StatefulSet controllers no longer force a resync every 30 seconds when nothing has changed.

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 3, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enisoc, jonsabo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 3, 2019
@anyasabo
Copy link
Author

anyasabo commented Apr 4, 2019

Thanks for the wording suggestion @enisoc, that seems reasonable.
/retest

@enisoc
Copy link
Member

enisoc commented Apr 4, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 4, 2019
@k8s-ci-robot k8s-ci-robot merged commit eee8af9 into kubernetes:master Apr 4, 2019
@anyasabo anyasabo deleted the ssetresync branch April 4, 2019 14:58
@savitharaghunathan savitharaghunathan mentioned this pull request Jul 30, 2019
Merged
k8s-ci-robot pushed a commit to kubernetes/website that referenced this pull request Jul 31, 2019
@savitharaghunathan @k8s-ci-robot
Fixing 404 link error in release notes 1.15 (#15588)
5f26042 
Pull request kubernetes/kubernetes#75622 was created by https://github.com/anyasabo. Updating 404 not found error with the right link in the release notes page of v1.15. (https://kubernetes.io/docs/setup/release/notes/)
@Huang-Wei Huang-Wei mentioned this pull request Sep 1, 2019
Merged
@zhujl1991 zhujl1991 mentioned this pull request Feb 11, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@foxish foxish Awaiting requested review from foxish

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@enisoc enisoc

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/apps Categorizes an issue or PR as relevant to SIG Apps. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

statefulset controller create pod too slowly
4 participants
@anyasabo @k8s-ci-robot @likakuli @enisoc