-
Notifications
You must be signed in to change notification settings - Fork 41k
add --all-namespaces to kubectl delete #73716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
set -o pipefail | ||
|
||
# Runs tests related to kubectl delete --all-namespaces. | ||
run_kubectl_delete_allnamespaces_tests() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't you need to call this from somewhere?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't you need to call this from somewhere?
Ah, I guess I did half the refactoring to match openshift.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't you need to call this from somewhere?
fixed
one question on the test, lgtm otherwise |
c0c63e1
to
e004aa7
Compare
|
@deads2k as an helper please run these: |
fd749cf
to
b2e7201
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@liggitt looks like your comment was addressed. LGTM 👍 |
/lgtm |
/retest Review the full test history for this PR. Silence the bot with an |
@@ -177,6 +177,7 @@ | |||
./test/cmd/core.sh | |||
./test/cmd/crd.sh | |||
./test/cmd/create.sh | |||
./test/cmd/delete.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you make this pass lint?
kubectl delete
should support--all-namespaces
. Since we now have CRDs, wanting to delete all of a particular type is a more reasonable use-case to support. There are also edges where I want this today.@kubernetes/sig-cli-maintainers
@enj since you hit it.