New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate and remove DynamicKubeletConfig (?) #100799
Comments
#61673 as well.
Link to the enhancement issue as well kubernetes/enhancements#281. |
the feature was enabled in kubeadm as optional, but we removed it recently. prior feedback from users was that they could not get it work with the kubeadm wrapped option or by following the official docs: dynamic reconfiguration of services is a interesting discussion, yet from what i've seen SIG Arch are mostly not in favor. |
I don't think that's in the same bucket... dynamic refresh of a time-bound portion of a configuration (like a CA bundle or an authentication token) seems very different from changing the configuration. |
i still consider it dynamic reconfiguration of a service, that may or may not have behavior changes. |
we discussed this in sig-node and @SergeyKanzhelev said he would explore this in more depth during 1.22. |
I agree with @liggitt that auto reload of the CA bundle is not in the same category of DynamicKubeletConfig. It's the difference between changing the filepath (dynamic config) and just reloading the file at a fixed location (CA reload). Sure it's technically a change but if config is specifying intent, and the intent is "reload this file periodically," then changing the target file is not changing intent. |
/assign @SergeyKanzhelev |
Hey all, question on the roll-out of this. Discussion seems to say that the you're going to look into this and this is behind a beta featuregate - not familiar with this feature - but which part of the deprecation policy would this fall into: https://kubernetes.io/docs/reference/using-api/deprecation-policy What release would this be targeted to be finally deprecated with feature gate removed? |
I think the relevant portions of the deprecation policy would be:
|
Let's track this work as a KEP so there are less bugs in k/k repository. Also helps with linking to the KEP - instead of linking PRs to this issue. /close |
@SergeyKanzhelev: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Note: the KEP is kubernetes/enhancements#281 (comment) |
Stuck in beta since
v1.11
:https://github.com/kubernetes/kubernetes/blob/master/pkg/features/kube_features.go#L37-L40
/sig node
The text was updated successfully, but these errors were encountered: